bandaloo / editour Goto Github PK

There's no validation that the files uploaded are actually present in the metadata file. Also the metadata field could be an invalid JSON string.

Right now, the blue suggestion buttons don't change when you change what's on the server.

Once you download a tour you have to upload it again under the same name or it will cause all kids of issues. The upload text input should be locked to prevent the user from changing it while in editing mode.

The front-end should show some kind of visual feedback when you click "upload", showing that the upload is in progress and either displaying an error or giving a success message when it finishes.

Requests should be made with the same protocol as the current page is on. If you try to get something over http on an https page it is usually blocked by browsers for security reasons

I think this problem is best addressed from the backend. That way you can get an error message on the frontend in the normal way — in one of those server message boxes.

Frontend reports a 404 to the user in one of the server message boxes when it's probably a different code

You should be able to drag the regions in the side bar to rearrange their order

With the "upload" tour name field blank type in a name under the "download" tour name field and press enter. It will inform you that you need to fill in the "upload" field even though you don't really need to

Add an API endpoint for DELETE requests to /tour/:name that deletes the tour

Uploading two or more files with the same filename will cause issues because the metadata needs to disambiguate which belongs to which region. If the front-end can rename files before they're uploaded that would be ideal.

'Edit' is more clear

The backend sometimes sends a 500 error with the message "Failed to unzip: Unable to write". I'm not sure why or what causes it but the files do get uploaded and added to the zip properly.

Favicons are cool

See this image. Tested on FireFox.

Add meta tags with stuff like og:title and og:description to the index page.

Have some UI element that shows the upload progress of a pending form submission

The front end should have some indicator that the upload has started but not completed yet (e.g. a spinner)

If you can delete points from a polygon you should also be able to add them

The server might return something that isn't a JSON in an error (for example, NGINX might send some HTML in case of a 504 gateway timeout). The front end should handle this and report an error to the user

https://petitti.org/assets/editour.png
Tested on Firefox on GNU/Linux

It doesn't work on Firefox with some privacy settings enabled either

There's no need for this pattern anymore. The regions list should simply be an array, and RegionCards should have a reference to those regions.

It's not readily apparent that to edit a point you have to click the "Info" dropdown (or even that it's possible to edit a point).
Also the "Download" button makes it seem like it downloads the tour, but it really doesn't. It should be more clear that it just starts editing an existing tour

the Unity JSON utility doesn't handle nested lists very well, which is lame

This hard-to-reproduce error is still occurring on the server

On the backend when you submit a tour name it does this:

const tourName = fields.tourName
        .trim()
        .toLowerCase()
        .replace(/\s+/g, "-")
        .replace(/[\/\?\=&]/g, "");

This makes the name more suitable to URLs, but might change it from what the user put in. For example, if the user uploads a tour with the name "My Tour", they won't be able to edit it by entering "My Tour" in the download field (they'd have to enter "my-tour"). To make it easier, apply the above transformations to the user entered download field text before sending a request to the server.

When it says "Downloading..." it just uses the color that was already there

You shouldn't have to visit a link to get the zip.

Way too much stuff is logged to the console during normal operation. This should be reduced

The <title> attribute on the index page is still just poly region. It should be something nicer like "Editour | Build and Edit Custom AR Tours"