banchanart / banchan Goto Github PK

adding the meta tags for twitter, facebook, slack, etc cards so links to studios render pretty

It makes more sense for each LiveView to be its own logical page, rather than try to shove a bunch of CRUD stuff into a single LiveView

Blocked on: #24

Perhaps to TailwindCSS?

Let's explore what this is actually gonna be like and how much more work it'll put in our hands.

Both the repo, and in the code

Ref: https://gigalixir.readthedocs.io/en/latest/getting-started-guide.html

a guide: https://medium.com/@jackacarlisle/image-uploads-with-aws-s3-elixir-phoenix-ex-aws-step-3-568ca6360c63

Don't need to do much here. Just display any user profile info we need, make sure the needed fields exist, and that users can edit their own profiles when logged in.

Involves sketching out banchan.
Sketching out ideas for using those graphics.
Sketch out the initial logo idea.

Create a document from discord convo outlining MVP and what remaining questions we need answers for.

• #9
• #12

Had a chat with a couple of artists about the adoptable and the ych scene, and need to go through it to pull data relevant for banchan.

AWS docs: https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/private-content-signed-urls.html#private-content-choosing-canned-custom-policy

See https://www.leanpanda.com/blog/authentication-and-authorisation-in-phoenix-liveview/#step-4-create-a-way-to-logout-a-user-and-close-all-hisher-sessions

Description: Replace repeating tailwind multi-component classes with apply

Tailwind Documentation on implementing apply

• #77
• #78
• #79
• #80

https://gist.github.com/chrismccord/2ab350f154235ad4a4d0f4de6decba7b looks pretty straightforward

Need to add @tag :skip above wip tests to skip them instead of commenting them out so that they show as skipped when tests are run.

support uploading directly from client to S3. We'll need this for things like profile images and the actual commissions.

Here are the errors from the command line:

Starting Dialyzer
[
  check_plt: false,
  init_plt: '/Users/skullbunnygalaxy/dev/github/dwg/banchan/_build/test/dialyxir_erlang-24.0.5_elixir-1.12.2_deps-test.plt',
  files: ['/Users/skullbunnygalaxy/dev/github/dwg/banchan/_build/test/lib/banchan/ebin/Elixir.Banchan.StudiosFixtures.beam',
   '/Users/skullbunnygalaxy/dev/github/dwg/banchan/_build/test/lib/banchan/ebin/Elixir.BanchanWeb.Components.Card.beam',
   '/Users/skullbunnygalaxy/dev/github/dwg/banchan/_build/test/lib/banchan/ebin/Elixir.BanchanWeb.UserAuth.beam',
   '/Users/skullbunnygalaxy/dev/github/dwg/banchan/_build/test/lib/banchan/ebin/Elixir.BanchanWeb.Components.Nav.beam',
   '/Users/skullbunnygalaxy/dev/github/dwg/banchan/_build/test/lib/banchan/ebin/Elixir.BanchanWeb.DenizenLive.Edit.beam',
   ...],
  warnings: [:unknown]
]
Total errors: 8, Skipped: 0, Unnecessary Skips: 3
done in 0m2.9s
test/support/channel_case.ex:1:unknown_function
Function ExUnit.Callbacks.__merge__/3 does not exist.
________________________________________________________________________________
test/support/channel_case.ex:22:unknown_function
Function ExUnit.CaseTemplate.__proxy__/2 does not exist.
________________________________________________________________________________
test/support/component_case.ex:9:unknown_function
Function ExUnit.CaseTemplate.__proxy__/2 does not exist.
________________________________________________________________________________
test/support/conn_case.ex:1:unknown_function
Function ExUnit.Callbacks.__merge__/3 does not exist.
________________________________________________________________________________
test/support/conn_case.ex:22:unknown_function
Function ExUnit.CaseTemplate.__proxy__/2 does not exist.
________________________________________________________________________________
test/support/data_case.ex:1:unknown_function
Function ExUnit.Callbacks.__merge__/3 does not exist.
________________________________________________________________________________
test/support/data_case.ex:21:unknown_function
Function ExUnit.CaseTemplate.__proxy__/2 does not exist.
________________________________________________________________________________
lib/banchan_web/views/layout_view.ex:1:unused_fun
Function render_template/2 will never be called.
________________________________________________________________________________
done (warnings were emitted)

Mockup of major pages for Banchan Art site

https://iacobson.medium.com/phx-gen-auth-and-oauth-for-a-phoenix-liveview-app-a19a27e6befa

I think we should have Facebook (because insta), Twitter, and maybe Google auth?

Document User Flows

https://hexdocs.pm/phoenix/Mix.Tasks.Phx.Gen.Live.html

https://hexdocs.pm/surface_formatter/0.5.1/readme.html

Real basic. Figure out what info we need and what needs to be hooked up to what. Allow users to create their own studios (this'll eventually require admin approval) and configure the ones they own. Add a page that lists a user's studios.

https://airtable.com/tblF8YI7ZkSVm1qwP/viwJt4QxAhT5NL6Wv?blocks=hide

Blocked on: #24

We want users to be able to configure two-factor auth using apps.

Ref: https://dashbit.co/blog/introducing-nimble-totp

Here's how to do it in Phoenix: https://hexdocs.pm/phoenix_live_view/uploads-external.html

We'll also need to either switch to the main Surface branch, or just pull in https://github.com/surface-ui/surface/blob/master/lib/surface/components/live_file_input.ex to get access to the live file input component wrapper.

Ref: #27

right now, as long as an account exist, we don't verify any emails. We should block access to some pages until the user's email is verified.

• Block access to commission submission
• Block access to studio creation
• Add nag-bar to Layout with link to resending verification

We need to keep at least the session controller endpoints for session setup and teardown, but I think everything else can mostly go. Let's make those forms interactive!

Controllers (and associated views) to Convert

• user_settings
• user_session
• user_reset_password
• user_registration
• user_confirmation

we're skipping several tests because they need to be rewritten for LiveView-related bits. Let's revive those to make sure everything is working right.

it's uhh.... kinda confusing right now, and mix quality has started switching the line endings around on me, so we might want to do this soon.

...but we need to wait until there's no PRs, and do it in one fell swoop.

Need to:

1. Find a Studio to commission
2. Apply for commission through a Slot
3. Artist needs to accept the commission. This locks that Slot. Artist may also turn down the commission with a message. Prepayment is collected immediately and held by Banchan.
4. Artist can request additional info/materials, and "assign" the commission to the customer at any time.
5. Customer can add stuff to a stream of comments/actions, and bounce it back to the artist
6. Artist updates commission status as it goes along.
7. Customer is able to message Artist through the commission page.
8. Artist and commissioner receive activity notifications as things move along.
9. Full payment is finalized and Artist is credited when the commission has been marked as complete, and final artifacts are uploaded.

If you try to visit a LiveView and that LiveView redirects you back to the login page, you won't be redirected back to the page you got bumped from after logging in. This kinda sucks.

Repro Steps

1. Log out
2. Go to a Studio page
3. Click through to request any offering
4. Log in after getting bumped to the login page

You'll be redirected to / instead of the commission submission form.

Notes

Phoenix doesn't let you access the http session from LiveView, so things are a bit tricky for us here. I can't really think of any way around this but we should probably address it at some point?

Dependabot brings up four security issues, which need more investigation.

Suggested changes by Dependabot.

• Upgrade path-parse to version 1.0.7 or later.
• Upgrade tar to version 3.2.3 or later.
• Upgrade glob-parent to version 5.1.2 or later.

trim-newlines is also an issue, but part of the issue is node-sass requiring a specific version of meow that requires a specific version of trim-newlines.

We're probably gonna be hosting stuff on S3, at least to start with, so that has to be set up.

• #68
• #69
• #70
• #71
• #72

Currently trying to fix it here: #46

Ref: https://adrian-philipp.com/notes/how-to-implement-infinite-scroll-with-phoenix-liveview

• Write beta signup page
• Hook up deploys and form on Netlify
• set up custom domain on netlify
• Do a small test w/ a couple of friends
• Set up and link privacy policy
• Set up analytics for tracking where people are coming in from: https://plausible.io/
• Add a link to the home page that goes to the beta page (keep in a branch)
• Go through the day-of checklist: https://github.com/BanchanArt/product/issues/21