bambla78 / pythonista_suncalculator_ipad Goto Github PK

https://www.python.org/dev/peps/pep-0008/#programming-recommendations

When catching exceptions, mention specific exceptions whenever possible instead of using a bare except: clause:

https://github.com/PyCQA/flake8-bugbear B001

Do not use bare except:, it also catches unexpected events like memory errors, interrupts, system exit, and so on. Prefer except Exception:. If you're sure what you're doing, be explicit and write except BaseException:.

https://realpython.com/the-most-diabolical-python-antipattern

mainprogram() is currently 600+ lines long and has a cyclomatic complexity of 66.
To improve readability and maintainability, it should be broken into multiple functions.

https://github.com/PyCQA/mccabe is included in flake8.
% flake8 --select=C9 --max-complexity=39 # The recommended setting is 10.

./suncalc.py:2803:1: C901 'mainprogram' is too complex (66)

https://en.wikipedia.org/wiki/Cyclomatic_complexity