balsamiqleon / jammming Goto Github PK

https://github.com/balsamiqLeon/jammming/blob/006e29a3add0fd49ee20f451d04f121cc21ebadd/src/Components/Playlist/Playlist.js#L20

The input element has a defaultValue and value. Since value is controlled by its props this causes an error in the console and should be avoided since it does not conform to React best practices. Instead try deleting defaultValue and put value={this.props.playlistName || 'New Playlist'}

When the user enters into the search input and presses enter, search is not initiated. Try putting a form tag around the search button.

It looks like a lot of the CSS is repeated in the component folder and also index.css.

Rubric Score

Criteria 1: App Creation, Folder Structure, and File Paths

• Score Level: 3 (meets expectations)
• Comment(s): Excellent job here, structure follows best practices and no issues with paths.

Criteria 2: Correct Implementation of User Flows (e.g. Searching, Token Generation, Save Playlist, etc.)

• Score Level: 4 (exceeds expectations)
• Comment(s): API implementation is flawless, keep it up!

Criteria 3: Proper JavaScript and JSX Syntax and Formatting

• Score Level: 4
• Comment(s): Formatting looks great, no issues

Criteria 4: Implementation Adheres to DRY Principles

• Score Level: 2 (approaches exceptions)
• Comment(s): There is a lot of repetition in the CSS, this causes a lot of overhead for the page and does not follow best practices.

Overall Score: 13/16

Overall the project looks and feels great! Always try to follow DRY principles and watch out for controlled inputs. Great job, keep it up!

https://github.com/balsamiqLeon/jammming/blob/006e29a3add0fd49ee20f451d04f121cc21ebadd/src/index.css#L1-L5

In the chome brower, setting #root to 100% causes the page to be cut off