Git Product home page Git Product logo

Comments (6)

pimterry avatar pimterry commented on August 18, 2024

@emirotin @jviotti @Page- I think we should:

  • Stop building on pushes and instead just build on PRs

  • Find a way to change the NPM config + build config so we only run the test suite once per job. I've got a plan for a reasonably nice solution to this that doesn't cause problems for pre-NPM4 users - I'll push a strawman in a minute.

Thoughts?

from balena-sdk.

emirotin avatar emirotin commented on August 18, 2024

from balena-sdk.

pimterry avatar pimterry commented on August 18, 2024

#242 is a run at a fix for the NPM issue here, and I've now disabled building on pushes for Travis. I can't see how to get at the equivalent settings for AppVeyor though, @jviotti I think you've got access - if you could change that to only build on PRs too that'd be great, thanks.

from balena-sdk.

jviotti avatar jviotti commented on August 18, 2024

Hi @pimterry ,

I made sure you have access to Appveyor by including it into the CLI/SDK GH team (which is explicitly added to Appveyor). After looking a bit around, I think the only way to accomplish what you're trying to do is by adding the following to appveyor.yml:

branches:
  only:
    - master

This will prevent builds for branches, but it looks that it will still build PRs (according to the docs). Give that a go and let me know if it still doesn't work, and we can get in touch with Appveyor's priority support.

from balena-sdk.

pimterry avatar pimterry commented on August 18, 2024

@jviotti Thanks! That pointer was enough to get me to the config option I was looking for: appveyor/ci#882. #244 turns this on.

Sorry for the PR flood! With that one though we should hopefully have most of these build issues in the SDK solved, for now 😄

from balena-sdk.

pimterry avatar pimterry commented on August 18, 2024

All done - we now run 25% of the tests we were running before, so I'm going to close this. Should drastically improve things. If we need to go further in future, we'll need to substantially refactor the actual flow of the tests, but I suggest we leave that unless we see more problems that'd make it necessary.

from balena-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.