The SDK doesn't throw errors when needed about balena-sdk HOT 3 CLOSED

Hi, can you provide an example with the arguments that you provide to the .create() call?
I would be interested at seeing the invalid name that causes this issue.

from balena-sdk.

Hi,

I used a colon (:) in the name, which caused the fail. So something like fleet:test.

from balena-sdk.

Hi @bartversluijs,
It seems that this fell through the cracks of my inbox...

I think the issue that you are facing is that you are not waiting for the returned promise to resolve.

This causes the auth.isLoggedIn() function to always state true, which isn't the case.

auth.isLoggedIn() returns a promise, which if used directly in an if statement could be confused with a true boolean, but if you console.log(sdk.auth.isLoggedIn()) your console should print Promise {<pending>}.
You can use .then() or await inside async functions. Let me also point you to our test cases that make sure that the returned promise resolves to false when there is no logged in user:

Similarly when calling application.create() with invalid parameters, the function will not throw synchronously (especially since the name validation is done by our backend), but it will instead return a promise that will be rejected. You can handle that case by either using .catch((err) => { console.log(err) }) or using try catch with await like:

try {
    const fleet = await sdk.models.application.create({
        deviceType: 'raspberrypi3',
        name: 'fleet:test',
        organization: 'thgreasinomembersorg'
    });
    console.log(fleet);
} catch (err) {
    console.error(err);
}

which should log something like:

BalenaRequestError: Request error: App name may only contain [a-zA-Z0-9_-].

Given that we do have test cases for these I will close the issue for now, but feel free to re-open or ask for further help here or in a new issue.

Kind regards,
Thodoris

from balena-sdk.