bakasurarce / hexchat-fishlim-reloaded Goto Github PK

the recipient is able to read my fished /me bla, but on my side i cant read his, which are shown as + OK encrypted.
using a cbc: key

See Hexchat bug #2639

Build info:

• Hexchat 2.16.0

Summary:

• FiSHLiM missing /key command to show original key set for a channel or user

@BakasuraRCE if you are on IRC please join #hexchat on Libera

Relaying a bug. User does not have github.

Other implementations of FISH for mIRC, Xchat, and Irssi included the /key command. This is missing from FiSHLiM. If you forget the stored key, you have no method to recover it from FiSHLiM.

To show the original key set for a user or channel the user would evoke the command.

/key <#channel>
/key <user>

See Hexchat bug #2638

Build info:

• Hexchat 2.16.0

Summary:

• Long messages fail to decrypt in Hexchat , returning unreadable ciphertext for the client

Tested

• Weechat 3.1 (fish module https://github.com/mawashii/weechat-fish)
• Irssi 1.2.0-2 (20190211)
• mirc 7.67 (FiSH 10 build Oct 10, 2020)
• Hexchat 2.14.3

@BakasuraRCE if you are on IRC please join #hexchat on Libera

Relaying a bug. User does not have github.

This may be related to the pull request on bug #2487 attempting to fix bug #1879

FiSHLiM is not decrypting long messages sent by other implementations of FISH or older builds of FiSHLiM, and returns ECB encrypted +OK messages. It may also effect CBC mode.

To trigger the bug the message sender must use a different irc client + different fish module and the receiver must be using Hexchat 2.16.0 with refactored FiSHLiM.

This bug can not be reproduced if two or more users are all communicating using Hexchat 2.16.0 or recent versions of FiSHLiM compiled from master.

There is a known bug which remains unfixed since a while in original fishlim: FiSHLiM utf-8 truncation problem #1879

It is related to a maximum allowed length of IRC messages. When the encrypted data is over this limit, it is just truncated instead of being redistributed multi-line.

There is a FiSHLiM re-written in perl which address this problem and its README demostrates a real case how this problem occurs here https://github.com/hexchat-ngfish/ngfish#proper-message-length-handling--no-data-corruption

The way how it's solved there is not very efficient but at least it works, so I thought maybe you would be interested in fixing this issue in your fork and official FiSHLiM, since your project is aimed at improving it.

It would be nice to have an option to turn it off/on.

Thanks your effort, but I encountered some trouble.

Sender: mIRC 7.64 + FiSH 10
Receiver: HexChat 2.14.2(FiSHLim 0.1.0 hcfishlim.dll)

1. When I use keyx with CBC key exchange On in mIRC to HexChat, HexChat would notice Received key exchange for CBC mode which is not supported. and mIRC says *** FiSH: Sent my DH1080 public key to xxxxx, waiting for reply ...

2. When I set key at CBC mode manually in mIRC, HexChat could not decrypt them.

By the way, /setkey ecb:key seems make the key to ecb:key at ECB mode rather than key at ECB mode
/setkey cbc:key seems make the key to cbc:key at ECB mode rather than key at CBC mode

Thanks!