badoo / codeisok Goto Github PK

This will make it faster to start reviewing code.

If you are doing a long review with a lot of files, seeing which one is selected is helpful to keep track of your progress. This works fine selecting files, but when you leave a comment the selected style for the file is lost so you can lose track of your place.

One of the main reasons for slowdown of diff rendering is we wait for the whole page to load before rendering diffs. But we can do it with partial HTML load as well. This will significantly improve the speed of diffs rendering.

When using treediff and if the number of changed files is about ~1k there are noticeable problems with performance: the frame rate is very low, click actions are executed with a significant delay.

Not sure what the cause of the issues: file tree or the contents (or both). Probably, we should implement some mechanisms for lazy loading and add only visible elements to DOM.

When you activate side by side view and Treediff mode is off, you can't tell which file is selected apart from reading the file contents.

The code colour switches to orange in sidebyside mode seemingly when it hits a template string and remains that way to the end of the file.

Haven't tested whether it's actually the template string causing the issue but for my case it was.

When you are typing some really long line of text without "manual" line-breaks — it is "overflowing". I think we can add support of "automatic" line-breaks here in CodeIsOK — as it works in native browser textareas.

Actual behaviour: https://yadi.sk/i/XAl3EeVAbySIuw
Expected behaviour: https://yadi.sk/i/-n1ZNnhWYfyfXA

Is there any documentation for how codeisok selects the default branch to compare with?

Sometimes we have an issue that it selects some random feature branch.

Thanks

In a diff when we are filtering for file extensions or modification attributes they should be added to the URL. This will make it easy to load and share pre-filtered diffs. And it can also significantly improve the performance of diffs.

Often times this causes frustration and should be a rather easy fix.

Добрый день! Не стартует контейнер после билда по инструкции.

Запуск
docker run -d --restart unless-stopped -p 80:80 -p 2222:22 --name codeisok -v codeisok:/local/codeisok -v codeisokmysql:/var/lib/mysql -v codeisokgit:/home/git/ codeisok

Логи
> docker logs codeisok

 * Starting MySQL database server mysqld
   ...done.
 * Checking for tables which need an upgrade, are corrupt or were
not closed cleanly.
ERROR 1045 (28000): Access denied for user 'debian-sys-maint'@'localhost' (using password: YES)
 * Starting OpenBSD Secure Shell server sshd
   ...done.
Warning: Using a password on the command line interface can be insecure.
ERROR 1045 (28000): Access denied for user 'root'@'localhost' (using password: YES)
 * Starting Mail Transport Agent (MTA) sendmail
   ...done.
 * Starting MySQL database server mysqld
   ...done.
 * Checking for tables which need an upgrade, are corrupt or were
not closed cleanly.
ERROR 1045 (28000): Access denied for user 'debian-sys-maint'@'localhost' (using password: YES)
 * Starting OpenBSD Secure Shell server sshd
   ...done.
Warning: Using a password on the command line interface can be insecure.
ERROR 1045 (28000): Access denied for user 'root'@'localhost' (using password: YES)
 * Starting Mail Transport Agent (MTA) sendmail
   ...done.

Steps to reproduce

• Start review on a diff in side by side mode
• Leave a comment on a line not part of diff
• Finish review
• Pretend you are another developer and open review in unified mode

Possible Solutions

• Show review comments in unified mode even if their lines can't be found
• Don't allow adding review comments on lines which are not a part of the diff

Switching modes loses the active file, it shows the first in the list instead.

• Open a branch diff with existing reviews
• Add comment
• Clicks another review link on the bottom dialog
• Add another comment (click Comment in comment dialog)

Actual Result

Nothing happens. (But after reloading a page I see new unfinished reviews)

Expected Result

We should either prevent user from switching reviews after starting a new one. Or show the comments for the new review on switch.

Steps to reproduce

1. Select a repo from the main page
2. Click on the "Reviews" tab

Expected Result

We see code reviews for that specific repository

Actual Result

We see code reviews for every repository in the company

Now tree diff displays the whole list of files on the right but the order of these files is not the same as the tree on the left.

It is very inconvenient since 1) usually files adjacent in the tree should be reviewed together but the scrollable list of file bodies doesn't follow this order 2) if you try to review just by scrolling file contents and then try to click on a file in the tree to temporary check something it is hard to find where you were before

We miss the support of code formatting in comments. I propose to add support of using of back-slashes for highlighting code snippets — e.g. like it is implemented in Slack – single back-quotes (`) for one-line code-snippets and three back-quotes (```) for multi-line code snippets.

Right now PHPSESSID cookie is a Session cookie so if a user closes their browser and goes back to codeisok they get logged out. This is too strict for a tool like this, we should have a reasonable cookie expiry like 1 week.

Wrong constant name https://github.com/badoo/codeisok/blob/master/.include/Redmine.php#L53

And may be api and url use as environment variables?

Hey there!

I'd like to report a security issue but cannot find contact instructions on your repository.

If not a hassle, might you kindly add a SECURITY.md file with an email, or another contact method? GitHub recommends this best practice to ensure security issues are responsibly disclosed, and it would serve as a simple instruction for security researchers in the future.

Thank you for your consideration, and I look forward to hearing from you!

(cc @huntr-helper)

This means developers can prevent accidentally closing pages while having typed a comment.

Создал в докере образ, подключился по вебу, создал репозиторий(а так же пытался копировать уже существующие репозитории в codeisok/repositories).
Проблема в том, что они не отображаются в вебе ни через минуту, ни через час.
Так же при запуске докер образа наблюдаю такую ошибку:

ERROR 1006 (HY000) at line 1: Can't create database 'gitphp' (errno: 13)

Возможно это связано