Git Product home page Git Product logo

go-bcd's People

Contributors

nvanbenschoten avatar sbahra avatar tamird avatar yanqi27 avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

nvanbenschoten yanqi27 etsangsplk xuegang

go-bcd's Issues

Test failure: cannot use tracer (type *TestTracer) as type Tracer in argument to Trace

Go 1.12.5, on Fedora Rawhide x86_64, latest master:

Testing    in: /builddir/build/BUILD/go-bcd-5d8e01b2f0438922289238fd3ba043761daf1102/_build/src
         PATH: /builddir/build/BUILD/go-bcd-5d8e01b2f0438922289238fd3ba043761daf1102/_build/bin:/builddir/.local/bin:/builddir/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/go-bcd-5d8e01b2f0438922289238fd3ba043761daf1102/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags "-X github.com/backtrace-labs/go-bcd/version.commit=5d8e01b2f0438922289238fd3ba043761daf1102 -X github.com/backtrace-labs/go-bcd/version=0 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '"
      testing: github.com/backtrace-labs/go-bcd
github.com/backtrace-labs/go-bcd
# github.com/backtrace-labs/go-bcd [github.com/backtrace-labs/go-bcd.test]
./bcd_test.go:119:13: cannot use tracer (type *TestTracer) as type Tracer in argument to Trace:
	*TestTracer does not implement Tracer (missing AddCallerGo method)
./bcd_test.go:143:19: cannot use tracer (type *TestTracer) as type Tracer in argument to Trace:
	*TestTracer does not implement Tracer (missing AddCallerGo method)
./bcd_test.go:152:18: cannot use tracer (type *TestTracer) as type Tracer in argument to Trace:
	*TestTracer does not implement Tracer (missing AddCallerGo method)
./bcd_test.go:160:18: cannot use tracer (type *TestTracer) as type Tracer in argument to Trace:
	*TestTracer does not implement Tracer (missing AddCallerGo method)
./bcd_test.go:174:20: cannot use &tracer (type *TestTracer) as type Tracer in argument to Trace:
	*TestTracer does not implement Tracer (missing AddCallerGo method)
./bcd_test.go:211:15: cannot use t (type *TestTracer) as type Tracer in argument to Recover:
	*TestTracer does not implement Tracer (missing AddCallerGo method)
FAIL	github.com/backtrace-labs/go-bcd [build failed]

Facilitate developing on 32-bit ARM

I've run into an issue compiling go-bcd on ARM because of the issue described in golang/go#16682. For an unknown reason, the system error number for PR_SET_PTRACEER_ANY is missing for the +build arm,linux variation of the sys/unix package. This causes compilation of bcd_sys_linux.go to fail.

I've been working around this by changing the conditional compilation tag at the top of bcd_sys_unsupported.go from

// +build !linux

to

// +build !linux arm

And adding the following line to the top of bcd_sys_linux.go

// +build !arm

Would you be open to a change to mark 32-bit ARM as unsupported but allow development on the system, at least until the referenced issue is resolved?

facilitate developing on non-Linux systems (OSX)

Can't build on OSX since the following linux-only syscalls are used:

# github.com/backtrace-labs/go-bcd
../../backtrace-labs/go-bcd/bcd.go:355: undefined: unix.Gettid
../../backtrace-labs/go-bcd/bcd.go:470: undefined: unix.PR_SET_PTRACER_ANY
../../backtrace-labs/go-bcd/bcd.go:471: undefined: unix.Prctl
../../backtrace-labs/go-bcd/bcd.go:471: undefined: unix.PR_SET_PTRACER

This could be hidden behind a build tag at the importing projects, but to facilitate development, perhaps a !linux build tag here with an implementation for which everything is a no-op could be given (I'm assuming that anything non-linux isn't currently supported).
In either case, documentation should address this issue (a lot of dev boxes run OSX).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.