backdrop-contrib / borg Goto Github PK

In a user's profile, the links to their website(s) aren't centred with the rest of the content on mobiles:

This comes from this CSS, however I couldn't work out when/why this was added. Removing it fixes the issue, but I suspect it's there for a reason (I just don't agree with it).

I think links should be centered like everything else.

The alt text for the Twitter icon in the top right corner of the Backdrop CMS home page has a typo. It should read "Follow us on Twitter" instead of "Follow os on Twitter".

The centering was added into the original borg by setting a line-height on the submitted paragraph as a hotfix. When we added updated information it becomes clear why this is not an elegant solution. Let's fix it!

Inline code is styled with a monospace font, but it's not obvious and can be hard to read:

I'd like to suggest similar styling to what GitHub uses (e.g. a background colour and padding. Here's what it could look like:

I just added the following CSS:

code {
  background: #eee;
  padding: 0.2em 0.5em;
  border-radius: 3px;
}

Note that this makes code blocks (e.g. <pre><code>...</code></pre> look a bit weird as the first line is indented slightly. I think this can be fixed by also adding the following CSS:

pre code {
  display: block;
  line-height: 1.5em;
}

We recently increased our base font size to bring our site up to google's minimum font size of 18px. In doing so, the icons in the header became HUGE and should be scaled down. Adding font-size: 14px; to those icons seems to do the trick.

Notice: Undefined property: User::$field_photo in borg_preprocess_node() (line 237 of /themes/borg/template.php).

Please include an Inline Style in the CKeditor settings so that a code style can be applied to words as a span.

This bug is visible on the API site when viewing on a screen size < 990px and > 768px.

The slogan doesn't wrap and sits on top of the absolutely positioned system-user-menu block.

Also, the system-user-menu block sits close to the bottom of the header and doesn't look nice anymore (since the font-size change I believe). Changing top: -5px; to top: -14px fixes this.

On the user registration page, any "description" text for a field is not displayed (there is CSS in components.css that sets it to display: none). This has the effect of hiding the useful information about the Username and Email address, as well as any description text in other fields that might be on that page.

Addressing the issue is not as simple as just removing that CSS, because restoring the description messes up the widths of the text boxes.

This can be seen on any of the backdropcms.org user registration pages, by going into the browser and clearing the CSS that hides the description fields. Example below from backdropcms.org: left is the current state, right is with the display:none commented out.

In backdrop-ops/backdropcms.org@041852b I added some CSS to fix the styling of the Showcase page, but I accidentally added it to the Borg theme in the B.org repo, as opposed to https://github.com/backdrop-contrib/borg

When the Borg theme in the B.org repo was updated, those changes were wiped and now the Showcase page shows in one-column rather than two.

This issue/PR is for adding the CSS back to the Borg theme, but in the right repo this time 😉

I'm having this error in the logs. I realized when I tried to change the logo of the site and didn't show up.

I tried to use the theme on a site that used the Grid format in Views, and when I looked at the Views page, it showed bunch of error messages, variants on these two:
Warning: Invalid argument supplied for foreach() in borg_preprocess_views_view_grid() (line 317 of /Applications/MAMP/htdocs/qdbackdrop/themes/borg/template.php).
....
Warning: Invalid argument supplied for foreach() in include() (line 25 of /Applications/MAMP/htdocs/qdbackdrop/themes/borg/templates/views-view-grid.tpl.php).

We have some great help text on the events site that takes people form the login form to the register form, and vice versa. I'd love to see that on all borg sites.

When one breakpoint changes to another, the menu can play up a bit. This is because the breakpoint value of, say, 48em is normally used as the min-width, but then sometimes it's used as the max-width. This means there's a 1px overlap where the menu does one thing when it should be doing another:

This was originally brought up in backdrop-ops/backdropcms.org#506

This issue was originally filed against the Forum repo since that's where the issue was noticed. However the code that causes the issue is in the Borg theme, hence this issue.

The submitted info for a forum post is vertically centred next to the author's image by setting the line-height to be the same height as the image. This works in most cases, except when the submitted info wraps to two lines. Then you get this:

We should work out a better way of vertically centring the submitted info so the line-height isn't affected...

The Borg theme removes the tabs from the login page (and other user/* pages:

On BackdropCMS.org this is fixed by adding a 'Forgot password?' link next to the Login button, however this happens in a custom module (https://github.com/backdrop-ops/backdropcms.org/blob/af96ca5a1df50ec30ac54d51e1d30eb033931b9b/www/modules/custom/borg_cleanup/borg_cleanup.module#L33), so other sites that use Borg (like Docs) have the reset link removed from the tabs area, but it's not added back anywhere...

I think if Borg removes the tabs, it should also add the link back where necessary (i.e. the code from the b.org custom module should be moved to the Borg theme).

FYI

We'll need to replace use of the each() function for PHP 7.4.

Deprecated function: The each() function is deprecated. This message will be suppressed on further calls in borg_book_next() (line 539 of borg/template.php). 

The screenshot is old and should be updated. It's displayed here: https://backdropcms.org/project/borg

BackdropCMS.org's log is full of these messages:

Notice: Undefined variable: more in include() (line 30 of /home/backdrop/repo/www/themes/borg/templates/node--project-search.tpl.php).

Didn't have time to look into it though.

There's a draft release which should be removed I think: https://github.com/backdrop-contrib/borg/releases/tag/untagged-5a27608e4642f951ea7b

The 1.1.12 version is here: https://github.com/backdrop-contrib/borg/releases/tag/1.x-1.1.12