ba-st / highchartsst Goto Github PK

They should be a new package with reified views on the Smalltalk side.
They should wrap the Highcharts components.
It would imply updating the examples to make use of the new classes.

For more details read: https://www.highcharts.com/docs/chart-design-and-style/style-by-css

In the README.md.

It open the following page: https://github.com/Mercap/HighchartsSt/issues it should be https://github.com/ba-st/HighchartsSt/issues instead.

Cheers,

Julien

For example...seaside is not a pre-requisite anymore as its part of the baseline again..

Anyway, a general quick pass would be nice for the release.

Add a process or improve import for the next iteration so that the accessors for the series and plot options that are implemented as extensions get their tests moved to extensions in the corresponding test packages.

It would be nice to have a script that automates the download and prepare the layout for filling our filelibraries (for future releases)

When trying to access the demo apps it will fail to load the javascript resources, so it wouldn't work.

Can we get a cypress branch? I'm fine to make it and keep it in my fork if you don't want it here.

We should add to the baseline a dependency with the minimum packages from Seaside.

Similar to the HighchartExamples

The current version has a manual data: method implemented for series column.
The importer should create the data: method in all components that represent a series type.

Improve available loading groups so the end users can choose the charting support to load in case they need only some chart types.

Hi guys,

Right now the default groups loads highcharts only and its examples:

    group: 'default' with: #('Core' 'Highcharts' 'HighchartsStExamples');

If we assume that default group would mostly be used by new comers (advanced users will use explicit groups to meet their needs), wouldn't it make sense to ALSO add highstock as well as its examples? Thoughts ?

Add to the importers a custom change to compile newChart and newStockChart in HighchartsNamespace as extensions.

If I do chart addSeries arearange that answers me a good instance of HighstockSeriesArearange. However if you inspect the result of chart series you will see the instance in there is a "a HighstockSeries ({""type"":""arearange""})" instead of a HighstockSeriesArearange.

The problem is that the methods like column, line , etc are NOT replacing the original HighstockSeries instance created by addSeries.

My workaround is this:

	series := HighchartsSeries new column.
	chart series add: series.

This class is currently in an extension.
We should find a json / documentation to allow it to be auto-generated.

The current version decides when to add comments to the classes based on the JSON, but it is not working for new classes.

series and yAxis by default return a new element the first time, and the same element when called again.
They should be changed to return a collection and never add a new element.
We should also create news methods addSeries / addYAxis which return a new element, and add them to the collection.

HighchartsSt used to be cross platform, functioning equally on GemStone and Pharo. Since the move to github it seems like that hasn't been maintained.

Can anyone give me an overview of how Boardwalk and ReniorSt are used in the project now? So I can decide whether to take them out of the GS fork or port them to GemStone. Id rather not have to include them if possible.

thanks

Highcharts8DeploymentMetadataLibrary>>csshighchartsCss
This library has the same code for both subclasses in the metadata and content for css/highcharts.css
This may be happening for Highstock as well

It's no longer used

Currently Highcharts6MetadataLibrary and Highstock6MetadataLibrary (and the online versions) reside in the same package.
We should leave online component, namespace and the canvas extension in a package, then create a separate package for the highcharts library and another for the highstock library.

This is the reason there's so low coverage.
Consider also that case:

• HighchartsZAxis implements events and events: so be aware of the test method names.

The current implementation of the series protocol requires also to set type: ...
Ideally creating a series of a specific type should do this automatically.

chart series column
            type: ‘column’ <-- SHOULD NOT BE REQUIRED
            index: index - 1;
            name: series name;
            data: (series dataAsPointsOn: aCanvas)

In previous versions the importer generated unit tests for all the imported methods.
This should be done again for the V6 branch.