Git Product home page Git Product logo

Comments (12)

aelij avatar aelij commented on July 26, 2024 1

@weinong I think you should keep this open until ADAL is fully removed from the repo (or track in a different issue). The library was deprecated a while ago and presents a security risk.

from kubelogin.

weinong avatar weinong commented on July 26, 2024

pending on token cache feature in Azure/azure-sdk-for-go#6602

from kubelogin.

weinong avatar weinong commented on July 26, 2024

AzureAD/microsoft-authentication-library-for-go#58
Azure/azure-sdk-for-go#6602 (comment)

from kubelogin.

weinong avatar weinong commented on July 26, 2024

Azure/azure-sdk-for-go#16643

from kubelogin.

weinong avatar weinong commented on July 26, 2024

adapter between ADAL and AzIdentity
https://github.com/jongio/azidext/blob/master/go/azidext/azure_identity_credential_adapter.go

from kubelogin.

aelij avatar aelij commented on July 26, 2024

The device code flow is much less convenient than interactive browser, so please migrate.

Additionally, ADAL has been deprecated and will no longer receive security updates:

If you choose not to migrate to MSAL before ADAL support ends in December, 2022, you put your app's security at risk.

from kubelogin.

weinong avatar weinong commented on July 26, 2024

Hi @aelij, yes, completely agree with you. I'm ramping up a new hire on this project. Hopefully we can tackle it soon. Though, I'm curious to learn what "inconvenience" you are referring to?

from kubelogin.

aelij avatar aelij commented on July 26, 2024

The fact that you have to copy the device code, open the browser, paste it and login, rather than having the browser simply open :)

from kubelogin.

weinong avatar weinong commented on July 26, 2024

Azure/azure-sdk-for-go#16643

from kubelogin.

fherbert avatar fherbert commented on July 26, 2024

Any update on the progress to migrate kubelogin to MSAL?

Would changing to MSAL result in the access_token be included in the _claim_sources member when a distrubted claim is returned?

We can't use kubelogin with anything other than AKS due to this limitation when users have more than 200 groups.

from kubelogin.

weinong avatar weinong commented on July 26, 2024

@fherbert we have some login modes implemented in msal such as interactive. Though, none of this would help you. That being said, I'd recommend configure your AAD app and k8s to use app roles for authorization instead of using groups

from kubelogin.

weinong avatar weinong commented on July 26, 2024

closing this issue as web interactive login mode is compatible with conditional access policy

from kubelogin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.