Git Product home page Git Product logo

Comments (7)

weinong avatar weinong commented on August 30, 2024 2

i will see if I can bring back the old code when --legacy is enabled next week

from kubelogin.

weinong avatar weinong commented on August 30, 2024

hmm. i think that is not supported in the new sdk (azidentity) that we migrated in v0.0.30. Are you managing your own k8s AAD configuration? would it be possible to migrate the server side?

from kubelogin.

bseenu avatar bseenu commented on August 30, 2024

Changing the server side will require api restart and we are seeing if we can avoid that

This is failing only for serviceprincipal flow, the deviceToken flow is still working as expected

from kubelogin.

weinong avatar weinong commented on August 30, 2024

are you okay to stay on v0.0.29 and work on your backend migration? I want to avoid reverting that change for an outdated sdk

from kubelogin.

bseenu avatar bseenu commented on August 30, 2024

Any reason why is the device code flow not switched to azidentity, it is still using adal library - https://github.com/Azure/kubelogin/blob/master/pkg/token/devicecode.go

I am not asking you to revert it, but can we use legacy flag to decide to use azidentity or adal for getting the token ?

from kubelogin.

weinong avatar weinong commented on August 30, 2024

i might migrate devicelogin to azidentity when i have free resources :)

your proposal is fine, but it still requires us to have outdated adal sdk.

from kubelogin.

ldemailly avatar ldemailly commented on August 30, 2024

Changing the server side will require api restart and we are seeing if we can avoid that

It's worse than that actually, it requires control plane rebuild and takes 30 minutes, so it's not an option

from kubelogin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.