The line at AzureSubscriptionExtensions throws null reference exception when param subscription is null.

We are seeing an issue in powershell module because of that as reported by multiple customers at Azure/azure-powershell#7406.

Normalize-Location in ScenarioTest's Common code doesn't return modified location value back.

I've found only one place where this location is used and it doesn't throw an error because in both cases it returns null

Assert-AreEqual (Normalize-Location $vaultLocation) (Normalize-Location $v.Location)

Also I think Normalize-Location could be used in Get-Location. When Get-Location filters locations for resource type it compares strings directly

$location = $resourceTypes.Locations | Where-Object { $_ -eq $preferredLocation }

If $preferredLocation is like westus the comparison would fail because resource type's locations are in human-readable format (West US). Normalizing both parts of comparison would help to avoid this issue.

Usage example: https://github.com/Azure/azure-powershell/blob/main/src/PowerBIEmbedded/PowerBIEmbedded/WorkspaceCollection/GetWorkspace.cs#L23
Attribute example: https://github.com/Azure/azure-powershell-common/blob/main/src/Common/CustomAttributes/CmdletDeprecationWithVersionAttribute.cs#40

There are important files that Microsoft projects should all have that are not present in this repository. A pull request has been opened to add the missing file(s). When the pr is merged this issue will be closed automatically.

Microsoft teams can learn more about this effort and share feedback within the open source guidance available internally.

Merge this pull request

Can anyone help me with this issue?

When I execute this command:

Import-Module PowerShellGet

I got this error:

Import-Module : Cannot find a variable with the name 'AmsiContext'.
At line:1 char:1
+ Import-Module PowerShellGet
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (AmsiContext:String) [Import-Module], ItemNotFoundException
    + FullyQualifiedErrorId : VariableNotFound,Microsoft.PowerShell.Commands.ImportModuleCommand

The second time it goes fine:

When going through the authentication flow with Azure there are several attempts to hit discover.azure.com.
The domain name is not documented anywhere and also always results in a name resolution failure.
This has been criticized by several enterprise security admins recently because they do not want to enable a URL that does not exist.
It is only used to handle an empty Metadata endpoint; we should change it to an endpoint that works or handle the nullOrEmpty case differently.

devdiv pipeline has been copied to dev.azure.com
there's no need for it to be run in CI any more

It looks like CONTRIBUTING.md was copied from azure-powershell and wasn't updated for azure-powershell-common. It makes things a bit confusing for newcomers 😃

I believe there is a typo in the file name use to check the version installed:

Should the file be named 'AzModuleVersions.json' ?

We have a test automation suite which runs multiple tests in parallel through Azure DevOps pipelines. These tests call Disable-AzContextAutosave when they start, and when multiple tests start at exactly the same time (in separate Powershell instances) we often get the following error:

Disable-AzContextAutosave : The given key was not present in the dictionary.
At C:\devops_agent_A\_work\_temp\azureclitaskscript1634703545536_inlinescript.ps1:6 char:3
+   Disable-AzContextAutosave -Scope Process | Out-Null
+   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Disable-AzContextAutosave], KeyNotFoundException
    + FullyQualifiedErrorId : System.Collections.Generic.KeyNotFoundException,Microsoft.Azure.Commands.Profile.Context 
   .DisableAzureRmContextAutosave
 
The given key was not present in the dictionary.
   at System.Collections.Concurrent.ConcurrentDictionary`2.get_Item(TKey key)
   at Microsoft.Azure.PowerShell.Common.Share.Survey.SurveyHelper.ShouldModulePrompt(SurveyHelper helper, String moduleName, Int32 majorVersion)
   at Microsoft.Azure.PowerShell.Common.Share.Survey.SurveyHelper.ShouldFlush(String moduleName, Int32 majorVersion, Func`4 condition, Action`3 updateModule)
   at Microsoft.Azure.PowerShell.Common.Share.Survey.SurveyHelper.ShouldPropmtSurvey(String moduleName, Version moduleVersion)
   at Microsoft.WindowsAzure.Commands.Utilities.Common.AzurePSCmdlet.EndProcessing()
   at System.Management.Automation.CommandProcessorBase.Complete()

We expected these calls to succeed, rather than throwing this exception. It appears that the relevant code lives in this repo but please redirect me if I'm in the wrong place!

The issue is that the attribute does not pring the property name, as can be seen on this line, the code needs to change.

I did a quick search and it seemed NuGet-4.7.0 and NupkgMerge are not used in our code. Their functionality may have been covered by ADO pipeline.

Todo:
Verify if the tools are needed. If not, remove them.