aztecprotocol / aztec-2-bug-bounty Goto Github PK

There are some problems with building a library Barretenberg. I run the "./bootstrap.sh" as described in the build instruction and received several CMake's build problems. Full log are here - CMakeBuildProblem.log
Seems that the problem is that several directories and files don't exist in repository. Missing directories and files are:

1. barretenberg/src/aztec/crypto/ecdsa
2. barretenberg/cmake/build.cmake
3. barretenberg/src/aztec/stdlib/hash/mimc
4. barretenberg/src/aztec/stdlib/encryption/ecdsa
5. barretenberg/src/aztec/noir

If I update CMakeLists files with problems (just by deleting the lines where the error occurs) I will receive several C++ build problem. Full log are here - C++BuildProblem.log. Seem that the problem occurred due to missing cpp-header files. E.g. barretenberg/src/aztec/plonk/proof_system/types/program_settings.hpp try to include barretenberg/src/aztec/plonk/proof_system/widgets/transition_widgets/mimc_widget.hpp (which does not exist) and we receive an error.

Looking at the code, Withdraw and WithdrawError events are declared in RollupProcessor.sol.
But they are never emitted. It would be helpful to tools analyzing Aztec usage if they were.

RollupProcessor's depositPendingFunds method generates Deposit events for token deposits, but no events for ETH deposits.

I think it should generate Deposit events for both (my preference) or neither.