Git Product home page Git Product logo

mod-npc-buffer's Issues

Misspell

uint32 level = player->getLevel();

getLevel -> GetLevel

28.95 /azerothcore/modules/mod-npc-buffer/src/npc_buffer.cpp:141:32: fatal error: no member named 'getLevel' in 'Player'; did you mean 'GetLevel'?
28.95 uint32 level = player->getLevel();

First buff in Buff.Spells is never applied

Current Behaviour

First buff in Buff.Spells list is never applied.

Expected Blizzlike Behaviour

First buff in Buff.Spells list should be applied.

Source

C++ vector indexes start at 0 not 1. Code like this should be 0 to 5 not 1 to 6.

    player->CastSpell(player, vecBuffs[1], true); // Prayer of Fortitude(48162)
    player->CastSpell(player, vecBuffs[2], true); // Greater Blessing of Kings(43223)
    player->CastSpell(player, vecBuffs[3], true); // Mark of the Wild(48469)
    player->CastSpell(player, vecBuffs[4], true); // Prayer of Spirit(48074)
    player->CastSpell(player, vecBuffs[5], true); // Prayer of Shadow Protection(48170)
    player->CastSpell(player, vecBuffs[6], true); // Arcane Intellect(36880)

Steps to reproduce the problem

  1. Right-click buffer npc
  2. Don't receive Prayer of Fortitude(48162) buff

Extra Notes

No response

AC rev. hash/commit

AzerothCore rev. f71ce38d7d00 2022-09-21 19:47:48 +0000 (master branch) (Unix, RelWithDebInfo, Static)

Operating system

Linux 5.19.7-1-MANJARO x86_64

Custom changes or Modules

No response

db startup error

Creature (Entry: 601016) has invalid unit_class (0) in creature_template. Set to 1 (UNIT_CLASS_WARRIOR).

creature->MonsterWhisper

Серьезность Код Описание Проект Файл Строка Состояние подавления
Ошибка C2039 "MonsterWhisper": не является членом "Creature". scripts C:\Build\azerothcore-wotlk\modules\mod-npc-buffer-master\src\npc_buffer.cpp 199
Серьезность Код Описание Проект Файл Строка Состояние подавления
Ошибка C2039 "MonsterWhisper": не является членом "Creature". scripts C:\Build\azerothcore-wotlk\modules\mod-npc-buffer-master\src\npc_buffer.cpp 287
Серьезность Код Описание Проект Файл Строка Состояние подавления
Ошибка C2039 "MonsterSay": не является членом "Creature". scripts C:\Build\azerothcore-wotlk\modules\mod-npc-buffer-master\src\npc_buffer.cpp 314

Arcane Intellect buff uses NPC abilities instead of player spells

Current Behaviour

https://www.wowhead.com/wotlk/spell=36880/arcane-intellect is an ability used by a NPC in the The Arcatraz which increases intellect by 100.

https://www.wowhead.com/wotlk/spell=42995/arcane-intellect is the L80 (Rank 7) player spell which increases intellect by 60.

And for lower levels https://www.wowhead.com/wotlk/spell=13326/arcane-intellect is used instead of the lower rank player spells.

Expected Blizzlike Behaviour

Arcane Intellect buff should give +60 intellect not +100.

Source

No response

Steps to reproduce the problem

  1. Right-click on buffer npc
  2. Receive Arcane Intellect +100 intellect buff

Extra Notes

No response

AC rev. hash/commit

AzerothCore rev. f71ce38d7d00 2022-09-21 19:47:48 +0000 (master branch) (Unix, RelWithDebInfo, Static)

Operating system

Linux 5.19.7-1-MANJARO x86_64

Custom changes or Modules

No response

NPC killed me

He spawned a necromancer unclickable who killed me, no idea if it's one of his spell he casts.

Ok it's the first buff

No longer buffs on right-click

Current Behaviour

Right clicking no longer buffs players. Nothing happens. This only started after the most recent module update. It used to work prior.

I also restored the .conf from the .conf.dist to test and still no right-click.

Expected Blizzlike Behaviour

Not blizzlike since it's a custom NPC, but it should cast buffs on players upon right-click.

Steps to reproduce the problem

  1. npc add 601016
  2. right-click new npc
  3. nothing happens

Extra Notes

This used to work prior to the latest update.

AC rev. hash/commit

AzerothCore rev. 099b6ab59a4a 2024-07-08 02:53:58 +0000 (master branch) (Unix, RelWithDebInfo, Static) (worldserver-daemon) ready...

Operating system

Debian 12.6

Custom changes or Modules

  • Modules configuration (static):
    |
    +- worldserver
    | +- mod-ah-bot
    | +- mod-anticheat
    | +- mod-aoe-loot
    | +- mod-assistant
    | +- mod-eluna
    | +- mod-individual-xp
    | +- mod-learn-spells
    | +- mod-npc-all-mounts
    | +- mod-npc-buffer
    | +- mod-npc-enchanter
    | +- mod-npc-services
    | +- mod-random-enchants
    | +- mod-skip-dk-starting-area

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.