Bug: Kael'thas Sunstrider Advisors not scaling about mod-autobalance HOT 10 OPEN

I am investigating this. So far I've eliminated one cause of the issue but there is something else going on that I don't understand.

I was trying to save some processing time by not modifying any creature that got respawned in but had already been adjusted. Something about how the advisors are spawned in causes them to be created twice without being removed from the world.

The previous check was adjusting the advisor the first time, but assumed that it had already done what it needed to the second time. Once I removed that check and attempted to re-process him, a different issue popped up.

Something in AC is telling AutoBalance that the creature is dead, so he is being skipped for alterations. I'm sure this has to do with the respawn logic, which uses dead states to force the game to respawn creatures. But as far as why this particular case is causing issues, I don't know yet.

from mod-autobalance.

Figured it out, I think there's a bug in AC. I'll get a PR in to fix it.

from mod-autobalance.

@alca-00

You can test my solution by using this branch of AzerothCore: https://github.com/kjack9/azerothcore-wotlk/tree/fix-force-respawn

You'll also need the version of AutoBalance in this branch: https://github.com/kjack9/mod-autobalance/tree/kjack9/issue172

from mod-autobalance.

First time trying to build a second server alongside my existing one so hopefully I didn't make any mistakes in the process
Using your branch + autobalance with these stock settings

So far I see the advisors still sitting at an unscaled HP despite these multipliers, the rest of the dungeon is scaling appropriately

from mod-autobalance.

So far I see the advisors still sitting at an unscaled HP despite these multipliers, the rest of the dungeon is scaling appropriately

Can you use these zip files just to be 100% sure you're running the modified code, please?

https://github.com/kjack9/azerothcore-wotlk/archive/refs/heads/fix-force-respawn.zip
https://github.com/kjack9/mod-autobalance/archive/refs/heads/kjack9/issue172.zip

Note that you'll need to rename the mod-autobalance-kjack9-issue172 folder to mod-autobalance when you put it in your modules directory.

I was able to perfectly replicate the issue, and those versions 100% fixed it for me. If the bug is still happening for you, I'm not sure what's going on.

from mod-autobalance.

Compiled again, bosses scale automatically. Sorry about that! Must've made a noob mistake, .server info gives me a different acore rev. than the first pic I posted so this one definitely is your intended zip file

from mod-autobalance.

Awesome, glad to hear that fixed it. I'll continue chasing the PR in the azerothcore repo and see if we can get a fix going that will take care of this.

from mod-autobalance.

Sorry for the delay in getting this resolved - still working to find a solution in the AC PR. Hopefully soon.

from mod-autobalance.

Idk if this helps, but on AzerothCore rev. b45a3fcac97b 2023-08-13 his advisors are scaling properly. Maybe you can compare both versions to see the difference?

from mod-autobalance.

Idk if this helps, but on AzerothCore rev. b45a3fcac97b 2023-08-13 his advisors are scaling properly. Maybe you can compare both versions to see the difference?

This topic seems abandoned, thanks for returning it. We will see what information there is about it.

from mod-autobalance.