azer / boxcars-archived Goto Github PK

Please take this entire description as well-intended constructive criticism. It is not meant to be offensive, but to help the project. I'm not singling out boxcars, I feel this way about a LOT of projects.

Reading the README, the only explanation given is

Easy-to-configure Static Web/Reverse Proxy Server in Go.

What does that mean? Why would I want to use it? What problem does it solve? This description is most useful to the developer who wrote it, not to the majority of potential users.

I'm a fairly experienced developer, familiar with what reverse proxies do, and even for me, there's nothing there to tell me why I should consider this instead of nginx. Yes, hidden down under benchmarks is a speed comparison with nginx, but having "it's similar in functionality to nginx, but faster" (or whatever is the most important distinction) would be cool up top.

If I were unfamiliar with nginx (or didn't know what a reverse-proxy did in general), and I was maybe a Python or Ruby developer who could take advantage of such a project, there's nothing in the description to tell me I can use this to serve my application. If I did a Google or Github search, I'd almost certainly never encounter this project with the keywords I'd use.

Anyone who's ever been trained in sales knows you always need to sell the benefits, not the features. Most people won't get excited about the specs of a gigabit fiber connection, but tell them they can do in two seconds what currently takes an hour and they'll get out their wallet.

Unfortunately the projects doesn't seem to be maintained anymore, which is sad, because it looks really promising. But anyway, right after #8 I'd like to have HTTP 2 support.

Hello.

Can you add a license to the project? Thanks!

I'm trying to use boxcars as static file server + reverse proxy on port 80, while dropping privileges, but I get an error:

  server Fatal: listen tcp :80: bind: permission denied +1

I think the solution to this is that boxcars needs to open a listen port first, then drop uid/gid privileges, then start the HTTP server (i.e. not calling ListenAndServe, but calling Serve).

A guy on hackernews had the time to post code but didn't want to send a pull request because github is hard or something. It might be worth considering doing something similar.

The secure.go file needs to be forked to support windows. See this file(http://golang.org/pkg/go/build/) for an explanation on how to implement via filenames.

You can only bind to one port. It would be a great feature to be able to bind to multiple ports, and have vhosts support multiple ports as well.

#I have 3 sites want to work behind the boxcars
but only one works.
here is the config

   "ost.abc.com": "http://192.168.11.221",
   "mail.abc.com": "https://192.168.11.173/mail",                                                                                                       
   "neodev.abc.com:": "https://192.168.11.21"
 }  

ost.abc.com is a simple LEMP website , and it works behind the reverse proxy
mail.abc.com is a webmail with self-signed certification

  handlers-of Setting up the HTTP handler that will serve https://192.168.11.173/mail +3
  servers Returning a reverse proxy server for https://192.168.11.173/mail. +3
  on-request Routing mail.abc.com/ +15045
  match Iterating patterns: / +15045
  match Matched mail.abc.com/ with the handler attached to /. +15045
  match Returning matching site for mail.abc.com/. +15045
2018/05/28 02:21:24 http: proxy error: x509: cannot validate certificate for 192.168.11.173 because it doesn't contain any IP SANs

any suggestions to fix the problem ?

and neodev.abc.com is a nginx-django website with a self-signed cetification
the error log below

  on-request Routing neodev.abc.com/ +145590
  match Nothing attached to neodev.abc.com or *.abc.com +145590
  match Unable to find any matching site for neodev.abc.com +145590

any suggestions ?

It would be cool to be able to specify something like

{
    ...
    "something.com": [ "redir", "http://internal.something.com" ],
    ...
 }

The package github.com/azer/debug is not thread-safe. Therefore whenever you call debug() you'll get a race condition. You can test it yourself with go run -race boxcars.go config.json:

On this line: https://github.com/azer/debug/blob/master/caption.go#L24 , colorOf is not locked and multiple goroutines are assigning on the same time to the map. And maps in Go are not thread-safe. I've opened a Pull-request for caption that solves this.

It's be nice to have the ability to load a SSL certificate and serve an encrypted connection over HTTPS.

go get github.com/azer/boxcars should replace go get github.com/azer/boxcars/boxcars
on first pages,

thanks

BR fino

like below:

{
  "indexFiles": "index.html,index.htm,index.php"
}

also, if all index files fail, should show a 404 page?