aymerick / douceur Goto Github PK
View Code? Open in Web Editor NEWA simple CSS parser and inliner in Go
License: MIT License
douceur's People
Contributors
Stargazers
Watchers
Forkers
gernest redforks jackdanger chris-ramon areahq nguyenvanduocit senviet influx6 mailproto pressly thumbtack sagansystems jeffizhungry gencer developgo czlhs jempe xushiwei forkkit artpar tsawler smagill thoughtmeeting blande18 standardgalactic ajunlonglive stjordanis bufsnake luisfurquim dewanggasurya oxiao agreffarddouceur's Issues
nbsp is replaced with space
The inliner library replaces is replaced with a space character. In my opinion, inliner should leave as it is. Here is a short test.
html := `
<html>
<head>
<style type="text/css">
body {
background-color: #f2f2f2;
}
</style>
</head>
<body>
<p> </p>
</body>
</html>`
inline, _ := inliner.Inline(html)
fmt.Println(inline)This prints:
<html><head>
</head>
<body style="background-color: #f2f2f2;" bgcolor="#f2f2f2">
<p> </p>
</body></html>Any quick fix for this?
Preserve Golang template structure
I'm seeing some oddities for this trivial example
package main
import (
"fmt"
"github.com/aymerick/douceur/inliner"
)
func main() {
tmpl := `
<html>
<head>
</head>
<body>
<div>
<table>
{{- range .Trash -}}<tr><td>{{.SomeId}}</td></tr>{{- end -}}
</table>
</div>
</body>
</html>`
compiled, _ := inliner.Inline(tmpl)
fmt.Println(compiled)
}
$ go run example.go
<html><head>
</head>
<body>
<div>
{{- range .Trash -}}{{- end -}}
<table><tbody><tr><td>{{.SomeId}}</td></tr></tbody></table>
</div>
</body></html>
It seems like there are a couple strange things happening here.
- A
tbodytag is automatically introduced for some reason - The Go template tags are re-arranged so that the compiled output cannot be re-used for templating
Preserve css style header after inlining.
This is more question/feature-request.
I want to preserve the existing CSS selectors after running through the inliner, eg;
Before
<html>
<head>
<style>
.my-class {
color: red;
}
</style>
</head>
<body>
<p class="my-class">Test</p>
</body>
</html>After
<html>
<head>
<style>
.my-class {
color: red;
}
</style>
</head>
<body>
<p class="my-class" style="color: red;">Test</p>
</body>
</html>So the my-class class is both inlined in the p element as well as preserved in the <style> header.
Infinite loop parsing CSS
The following code loops forever in the latest version:
package css
import (
"testing"
"github.com/aymerick/douceur/parser"
)
func TestInfiniteLoop(t *testing.T) {
parser.Parse(`
@media ( __desktop ) {
background-color: red;
}
`)
}Repository activity
I use this code for my mail service, but would like to know if there is any activity. I did a lot of refactoring and added Renovate to my fork.
If interested we could integrate the changes into this repo.
Is there any activity on this repo anyway? I noticed old PR's and issues that are not being replied to/merged or resolved in any way
Problem with parsing prefixed keyframes
With this CSS
@-webkit-keyframes segment-spin {
from {
-webkit-transform: rotate(0deg);
transform: rotate(0deg)
}
to {
-webkit-transform: rotate(360deg);
transform: rotate(360deg)
}
}I get:
Unexpected } character: CHAR (line: 11, column: 1): "}"
I think it's because it's not a recognized "AtRule". This works just fine to parse:
@keyframes segment-spin{
from{-webkit-transform:rotate(0deg);transform:rotate(0deg)}
to{-webkit-transform:rotate(360deg);transform:rotate(360deg)}
}
Vendor prefixes makes me cry at night, but a possible solution would be to extend
this line.
But pardon me, why maintain a list like that? What other strings that starts with a @ can't all be considered "at rules"? E.g this function could be something like:
func (rule *Rule) EmbedsRules() bool {
return strings.HasPrefix(rule.Name, "@")
}No?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.