aym1607 / do_more Goto Github PK

There is no editing functionality for Events.

The task model uses ints to encode the priority, this could lead to confusion and bugs.
Change it to use an enum. Add the parsing capabilities needed to interact with firestore.

the enum should look something like:

enum TaskPriority {
    low,
    medium,
    high,
}

The upload process takes a long time and waiting for it to be done in the new image screen would not be good for UX.

Implement a snackbar or something similar in the home screen that shows the progress of the files currently being uploaded.

For example:
when you update the priority of a task, the properties of the user and the event don't get updated.

This happens with almost any update regarding a task.

Most classes and widgets are missing Dart docs.

The models use named constructors and the code necessary to make it work with Equatable is too verbose and unnecessary. This is because the call to the super constructor (Equatable) complains when accessing non static members.

sticking to overriding hashCode and the == operator for now.

The tasks list is not necessary since tasks have an owner and event property that lets them be queried by this parameters, keeping track of this information inside user and event models only causes more queries to firestore when making updates and adding new tasks.

The NewTaskScreen should be renamed to TaskScreen and should be used both to add a new task or edit an existing one.

Try to figure out a way of stopping the controller from returning the cursor to the origin when rebuilding if text is already present in the input.

In contrast to the http package, cloud_firestore does not provide a mock instance.

We have to use mockito to test the methods inside the provider.

the following file provides an example on how to test using it:
https://github.com/brianegan/flutter_architecture_samples/blob/3fae7fbc01fc1dc87cbfee7208370eb854879b03/example/firebase_flutter_repository/test/firebase_flutter_repository_test.dart

The names for the blocs currently don't have the word screen in their names, this can cause confusion specially with the event screen whose bloc is called event_bloc. This doesn't provide enough information about the purpose of the bloc.