aws-samples / graviton-workshop Goto Github PK

Running the elasticsearch lambda from the workshop fails with:

[ERROR] Runtime.ImportModuleError: Unable to import module 'insert_into_index': cannot import name 'RequestsHttpConnection' from 'elasticsearch'

The elasticsearch version installed is v8.2.3 which no longer has RequestsHttpConnection, amongst other major changes.

You can fix e.g. elasticsearch==7.17.4 in: graviton2/elasticsearch_graviton/lambdas/requirements.txt, or try to port the code to >=v8.x, though the ES on the server side is v7.9 so that might not be compatible.

For all the other packages in the requirements files in this repo, I also recommend locking the versions to prevent similar issues.

We have a lot of partners using Terraform, will it be possible to include Terraform Graviton2 workshop as well? I can help write most of the Terraform code.

https://github.com/aws-samples/graviton2-workshop/blob/1ecef2ca1830d447beca5ca2937c1b80a5bf88e1/graviton2/cs_graviton/eks_graviton2.py#L34

This line unfortunately is deprecated now, and the version of the CDK library also limits using the latest versions of EKS (which are 1.25 as of this update). So if possible would recommend at a minimum update to 1.22 or higher as the CDK library in this workshop allows.