aws-samples / aws-codecommit-pull-request-aws-codebuild Goto Github PK

In correct description of what the lambda does at
https://github.com/aws-samples/aws-codecommit-pull-request-aws-codebuild/blob/master/base-layer.yaml#L140

What is the correct way of creating markdown in CodeCommit comments so that CodeBuild badge images are visible inline in CodeCommit? In my projects, I found that the CodeBuild comments containing links to CodeBuild badges are rendered as external links instead of showing the actual badges, e.g.

When clicked on, the browser opens a new window / tab with the build badge visible.

The implementation looks correct, in the CodeBuildResultFuction[sic], the link to the failing CodeBuilds evaluates to

![Failing](https://s3-eu-west-1.amazonaws.com/codefactory-eu-west-1-prod-default-build-badges/failing.svg "Failing")

and the passing CodeBuilds

![Passing](https://s3-eu-west-1.amazonaws.com/codefactory-eu-west-1-prod-default-build-badges/passing.svg "Passing")

In GitHub markdown (above) and in the blog post, these images are visible inline correctly:
.

Note 1, manual copy / paste of

![Failing](https://s3-eu-west-1.amazonaws.com/codefactory-eu-west-1-prod-default-build-badges/failing.svg "Failing")

into a new CodeCommit comment also renders erroneously as an external link:

Note 2, when changing the links to CodeBuild badge urls the images are displayed correctly inline in the comment.

s3-us-east-1 is not a valid S3 endpoint.

See:

https://docs.aws.amazon.com/general/latest/gr/rande.html#s3_region

The cloud formation template has a typo in the CodeBuildResultFuction definition (it should read CodeBuildResultFunction)

base-layer.yaml:167:  CodeBuildResultFuction:
base-layer.yaml:170:      FunctionName: "CodeBuildResultFuction"
base-layer.yaml:232:  CodeBuildResultFuctionArn:
base-layer.yaml:234:    Value: !GetAtt CodeBuildResultFuction.Arn
base-layer.yaml:236:      Name: "CodeBuildResultFuctionArn"
pipeline-example.yaml:173:        - Arn: !ImportValue CodeBuildResultFuctionArn
pipeline-example.yaml:185:      FunctionName: "CodeBuildResultFuction"

Hi,

I am new to cloudformaiton. The article and associated cloudformation codes were really helpful and it worked. Only one question I had was that template.yaml file is referenced in the pipeline yaml but it is not attached with this set of codes. Am I missing it? What should that template.yaml file contain? Would it contain deployment cloudformation details?

Hi team, Can anyone help in CodeBuildResultFuction to publish post pull request comment also on SNS Topic. This would be very helpful for us to be notified on email and CI/CD workflow.

Thanks
.