Git Product home page Git Product logo

cloudwatch-common's Issues

Clarify behavior when metric unit is not found

As one can see here

cloudwatch-common/cloudwatch_metrics_common/include/cloudwatch_metrics_common/utils/metric_object.h

Line 149 in 2d8f586

datum.SetUnit(Aws::CloudWatch::Model::StandardUnitMapper::GetStandardUnitForName(unit_name));

If the user-specified unit (which is a free-form std::string) is not found in unit_mapper, it will fallback to using the AWS C++ SDK's GetStandardUnitForName() function to find the corresponding relevant StandardUnit. GetStandardUnitForName() may return StandardUnit::NOT_SET.

Is this the best behavior? Why have a unit_mapper if the AWS C++ SDK already provides a GetStandardUnitForName() function?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.