awesomemotive / edd-discount-widget Goto Github PK

When saving an instance of this widget, if the "Hide Expiration" checkbox is left empty, I'm getting an undefined index notice:

PHP Notice:  Undefined index: hide_exp in \plugins\edd-discount-widget\edd-discount-widget.php on line 98

To reproduce:

1. Add a new discount widget to your sidebar.
2. Check your error logs.

[29-Jul-2021 10:36:27 UTC] PHP Warning:  Undefined array key "hide_exp" in EDD-Discount-Widget/edd-discount-widget.php on line 94

EDD_Discounts_Widget class public methods lack visibility.

EDD_Discounts_Widget::get_discounts() needs full rewrite. Looks like it doesn't work, but in any case it doesn't do any check so it throws notices and fatals even when you add it. Especially important with widgets block editor which does live preview.

Constructor needs to be rewritten.

If you want to use plugin, you won't know what it really does and what to do unless you are very advanced user.