Git Product home page Git Product logo

acquia_connector's Introduction

aweingarten

CircleCI Dashboard aweingarten Dev Site aweingarten

acquia_connector's People

Contributors

andrewyang avatar bjeavons avatar goba avatar grantgoodman avatar ioskevich avatar irek02 avatar itafroma avatar jacobsingh avatar janusman avatar krisolafson avatar mkalkbrenner avatar nickveenhof avatar pwolanin avatar robloach avatar steveedwardsacquia avatar stmixnovich avatar varvashenya avatar vladpavlovic avatar

Watchers

 avatar  avatar

Forkers

gauravgoyal

acquia_connector's Issues

Move Diagnostics Information From CMI to Status

Story

As a developer who uses CMI I want to be able to export CMI and expect it to not require reexports based on heartbeat of diagnostics being updated.

Implementation Details

[] Review all the CMI Varibles and move items that are in CMI to state where appropriate.
[] Ensure that the module can reinitialize the state on cron without issues or CMI headaches

Fix Dependency Injections Coding Violationss

User story

As a developer I want my user to leverage dependency injection so that it's testable, and following drupal best practices.

Implementation Details

[] Run phpcs with drupal-practice standards
[] Ensure that all the dependency injection violations are fixed.
[] see if there are opportunities for better utilizing dependency injection

Review CMI For Unneeded Values: Require Acquia Input

Story

As a developer I want to store the minimally necessary set of CMI for the Acquia connector module.

Context

Currently there is an insane number of variables being stored in CMI. Many of them may not be necessary.

Implementation details

[] Review the variables
[] Evaluate which ones are actually needed by Acquia/Insights
[] Kill the ones that don't matter

Add PHPCS to build

User Story

As a user I want to ensure that the module adheres to drupal coding standards.

Implementation Details

[] Add PHPCS to the travis build.
[] Set it up to scan the files changed in the PR and run the scan only on the changed files. Why only the changed files? There are too many errors to fix in a single PR that require too much code refactor.

Refactor Travis-CI File

User Story

As a user I want a modern travis-ci build.

Implementation Details

[] Take the lightning travis builds as an example and apply it here
[] Confirm that simpletest, phpunit, and behat tests are executed

Test Coverage

Update and clean up the test cases so that they actually work and test all different cases and codepath.

Check the code coverage and ensure that PHPUnit tests cover a majority of the code

Run PHPCBF on the codebase

User Story

As an engineer I want the module to adhere to community coding standards

Implementation Details

[] Run PHPCBF on codebase

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.