avinal / blowfish Goto Github PK
View Code? Open in Web Editor NEWBlowfish Encryption Algorithm Implementation in CPP.
License: MIT License
Blowfish Encryption Algorithm Implementation in CPP.
License: MIT License
Hello, I tried to use your library but couldn't get it to work.
I'm migrating some Rust code to C++ (yeah, sad), so I had a reference to compare.
I found a coulple of bugs:
Line 238 in b6931e3
Since key
is a string, key[j]
returns a signed char, which breaks my keys that are arrays of unsigned chars. So I changed:
data = (data << 8) | (unsigned char)key[j];
imho the key should not be a string
Lines 254 to 260 in b6931e3
The array should be indexed by k
instead of j
.
Sboxes
in being indexed incorrectly in F
:
Lines 269 to 277 in b6931e3
I changed it to (like the reference):
a = x >> 24;
b = (x >> 16) & 0xFF;
c = (x >> 8) & 0xFF;
d = x & 0xFF;
After those changes, I get the same results as in Rust!
Hope this helps someone who comes across this library
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.