Originally reported in <a class="issue-link js-issue-link" data-error-text="Failed to

The following things must be ensured: <li class="t

Because shortcodes and blocks are processed at different times, a shortcode can be output without necessary dependencies on the page about pym-shortcode HOT 4 CLOSED

automattic commented on August 25, 2024

Because shortcodes and blocks are processed at different times, a shortcode can be output without necessary dependencies on the page

from pym-shortcode.

Comments (4)

benlk commented on August 25, 2024

The following things must be ensured:

every Pym instance on the page is initialized

Here are the solutions that I can think of:

string matching and global variables and filters to put the `pymsrc` script tag at the start of the_content()

Add a filter to the_content that checks for the presence of the string 'pym', and if it is there, sets a global "maybe" variable to true
In the pym renderer, if it is called, if the tag doesn't have its own pymsrc, set a global definitely variable to true. If pymsrc is set, then instead output the pymsrc's tag
In a filter running on the_content that runs at a very late priority, like 100, if $maybe and $definitely, prepend the_content with a script tag that registers the appropriate pymsrc.

Enqueue the `new pym.Parent` in the footer

Everytime we would output a <script>var pym_1 = new pym.Parent('pym_1', 'https://f.benlk.com/graphics/heartbeat-abortion-bills/child.html', {})</script> , instead of outputting it then, add it to the footer with a generated callback function that has the correct variables inserted into its call.

This doesn't move the location of the pymsrc tag starting Pym, but it also does not prevent addressing #33 by enqueuing the pymsrc tag in the wp_footer as long as the function outputting that tag is enqueued at a higher priority.

from pym-shortcode.

benlk commented on August 25, 2024

I asked in #wordpress on freenode IRC, and received feedback to the effect that the best place to put those script tags is in <head> or at the end of <body> with wp_footer.

from pym-shortcode.

benlk commented on August 25, 2024

My worry is that someone using this plugin is going to be using WordPress in a way that powers a non-main-website content presentation, and their content presentation is going to render the_content() as HTML with scripts and stuff, but without any of the dependency-satisfying code from wp_footer.

from pym-shortcode.

benlk commented on August 25, 2024

Feedback in #wordpress on newsnerdery.org Slack from several people also recommends wp_footer.

from pym-shortcode.

Recommend Projects

Because shortcodes and blocks are processed at different times, a shortcode can be output without necessary dependencies on the page about pym-shortcode HOT 4 CLOSED

Comments (4)

string matching and global variables and filters to put the `pymsrc` script tag at the start of the_content()

Enqueue the `new pym.Parent` in the footer

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

Comments (4)

string matching and global variables and filters to put the pymsrc script tag at the start of the_content()

Enqueue the new pym.Parent in the footer

Related Issues (20)

Recommend Projects

Recommend Topics

Recommend Org

string matching and global variables and filters to put the `pymsrc` script tag at the start of the_content()

Enqueue the `new pym.Parent` in the footer