AMP support? about pym-shortcode HOT 6 CLOSED

@claudiulodro Yes, we'd love to have your PR here.

from pym-shortcode.

There's some discussion going on about this in the AMP Project

from pym-shortcode.

https://amp-wp.org/documentation/playbooks/custom-shortcodes-and-widgets/ describes the function is_amp_endpoint() and amp_is_canonical() which we might use with some of the filters added recently to change the output embed code on the page. However, AMP iframe tags aren't 100% compatible with Pym; they use a different postMessage syntax. We'd need to link out to AMP's docs for how to initialize using the amp iframe code versus Pym.js, and we'd need to make these tests ourselves.

from pym-shortcode.

I have a proposed "good-enough" solution for this at Automattic/newspack-plugin#276. Let me know if you want it in this plugin and I'll open a PR here. I'd definitely prefer to contribute it upstream to this plugin instead of maintaining it as a tweak in Newspack.

from pym-shortcode.

#62

from pym-shortcode.

Thanks! We'll take a look as soon as we can.

from pym-shortcode.