Git Product home page Git Product logo

action-rollback's People

Contributors

coreybutler avatar dependabot[bot] avatar ssmirr avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

action-rollback's Issues

Error: Reference does not exist

Hello, I'm using

https://github.com/author/action-rollback/tree/1.0.3#workflow

      - name: Rollback release if unsuccessful
        if: ${{ cancelled() || failure() }}
        uses: author/action-rollback@stable
        with:
          release_id: ${{ steps.create-release.outputs.id }}
          delete_orphan_tag: true
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

and I'm getting the error:

image

If I delete always_delete_tag I still get the error Error: Reference does not exist but not the warning. I'm more concered with this error. Where can it be coming from? The release entry is indeed removed so the release_id works well.

New Feature: Option to not throw an error if the tag is missing?

I have a workflow where I'm removing the latest release and replacing it with a new one. But the first run of the workflow where no release exists experiences an error because there is no tag to delete. I haven't been able to find a way to determine, without failing the workflow, if a tag exists or not so maybe this option could be added to this action?

Stable branch is missing schema for delete_orphan_tag

Issue:

Cannot use delete_orphan_tag when running from @stable because the schema for that option does not exist in the stable branch.

On master: https://github.com/author/action-rollback/blob/master/action.yml#L14-L16
On stable: https://github.com/author/action-rollback/blob/stable/action.yml#L7-L13

How To Reproduce:

      - name: Rollback Release if publish failed
        if: failure()
        uses: author/action-rollback@stable
        with:
          tag: ${{ matrix.package.tag }}
          delete_orphan_tag: true
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Produces:

Warning: Unexpected input(s) 'delete_orphan_tag', valid inputs are ['release_id', 'tag']
Run author/action-rollback@stable
  with:
    tag: monorepo-sandbox-a-v1.1.0
    delete_orphan_tag: true

Release 1.0.3 doesn't find module '@actions/core'

Our builds broke shortly after the new release 1.0.3 arrived. I've tested the build with @stable, @1.0.0, and @1.0.3: @stable/@1.0.3 fail, while @1.0.0 works as expected.

How we use the action:

- name: Delete Previous Release
  uses: author/action-rollback@stable
  # step fails, if tag doesn't exist in the first place; but that's ok!
  continue-on-error: true
  with:
    tag: ${{ env.release_tag }}
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

How it fails with 1.0.3:

Run author/[email protected]
internal/modules/cjs/loader.js:800
    throw err;
    ^

Error: Cannot find module '@actions/core'
Require stack:
- /home/runner/work/_actions/author/action-rollback/1.0.3/index.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:797:15)
    at Function.Module._load (internal/modules/cjs/loader.js:690:27)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/home/runner/work/_actions/author/action-rollback/1.0.3/index.js:1:14)
    at Module._compile (internal/modules/cjs/loader.js:959:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Function.Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1047:10) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/runner/work/_actions/author/action-rollback/1.0.3/index.js'
  ]
}

Readme typo

Just a small issue in the readme, where it lists the parameter as id instead of release_id

Deprecation warning regarding Node.js 12

Issue:

Using the action reports a deprecation warning:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: author/action-rollback.

How To Reproduce:

Include the action in a workflow file and run the corresponding workflow.

Expected Behavior:

No deprecated features are being used.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.