The api_nestjs_typescript_hello-world's discuss from auth0-developer-hub

api_nestjs_typescript_hello-world's Issues

Secret is not cached

Both guards are redefining the jwt functions on every call. In consequence, every API call leads to a new call to Auth0 - very bad for performance.

Looking at https://github.com/auth0-developer-hub/api_nestjs_typescript_hello-world/blob/main/src/authorization/authorization.guard.ts#L22, I think it should be:

...
export class AuthorizationGuard implements CanActivate {
  private validateAccessToken = promisify(auth());
  
  async canActivate(context: ExecutionContext): Promise<boolean> {
    const request = context.switchToHttp().getRequest<Request>();
    const response = context.switchToHttp().getResponse<Response>();

    try {
      await this.validateAccessToken(request, response);
...

Same for https://github.com/auth0-developer-hub/api_nestjs_typescript_hello-world/blob/main/src/authorization/permissions.guard.ts

Please do not use this repository as is.

Missing auth() parameters

Hey auth0 team,

I got stuck with the missing parameters for the auth() call in:

api_nestjs_typescript_hello-world/src/authorization/authorization.guard.ts

Line 28 in eeb2ddc

const validateAccessToken = promisify(auth());

Am i missing something or does this need to be fixed?

I simply went with

    const validateAccessToken = promisify(
      auth({
        issuerBaseURL: this.ISSUER_BASE_URL,
        audience: this.AUDIENCE,
      }),
    );

Recommend Projects