Git Product home page Git Product logo

binreadergui's Introduction

binreadergui's People

Contributors

autergame avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

Forkers

ujhyesp

binreadergui's Issues

Opening .bin files doesn't work

I seem to be unable to open any .bin files using the latest version.

After running GetOpenFileNameA on line 347, the file path is in openFile_temp (line 337). On line 349, the first character of openFile is checked, but the contents of openFile can still be 0 at this point. Moving the memcpy on line 351 outside of the if-statement seems to fix the issue.

ofn.lStructSize = sizeof(ofn);
ofn.hwndOwner = glfwWindowNative;
ofn.lpstrFile = openFile_temp;
ofn.nMaxFile = MAX_PATH;
ofn.lpstrFilter = "*.bin";
ofn.nFilterIndex = 1;
ofn.lpstrFileTitle = nullptr;
ofn.nMaxFileTitle = 0;
ofn.lpstrInitialDir = openPath;
ofn.lpstrTitle = "Open Bin File";
ofn.Flags = OFN_PATHMUSTEXIST | OFN_FILEMUSTEXIST | OFN_NOCHANGEDIR;
if (GetOpenFileNameA(&ofn) == TRUE)
{
if (openFile[0] != '\0')
{
myassert(memcpy(openFile, openFile_temp, MAX_PATH) != openFile)
myassert(memcpy(openPath, openFile, MAX_PATH) != openPath)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.