austintgriffith / burner-core Goto Github PK

getDisplayValue = (value, decimals=2) => {
    const displayVal = utils.fromWei(value.toString(), 'ether');
    if (displayVal.indexOf('.') !== -1) {
      return displayVal.substr(0, displayVal.indexOf('.') + decimals + 1);
    }
    return displayVal;
}

By using utils.fromWei it implies that the base unit is always 10^18 away from 1. While it isn't part of the IERC20.js interface ABI, it's very common for tokens to use the ERC20Detailed definition (https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/ERC20Detailed.sol) which may specify a different number of decimals than 18.

Suggest maybe update ERC20Asset, add a new optional parameter; decimals and do some fancy BigNumber mathematics to display the token appropriately rather than fromWei. Alternatively, create a new subclass ERC20AssetDetailed which can implement this functionality.

A cool future way might be to include the ERC20AssetDetailed ABI and actually call the decimals() function to determine appropriate decimals on construction of the Asset.