austinorr / swmmnetwork Goto Github PK

currently there are key errors looking up positions if the subcatchment name is an integer. this is likely a pandas issue which tries to autocast things if it can. sometimes helpful unless you always need string keys.

uppercase join broken for pollutant table in scenario.py

SWMM inp files are not case sensitive. Artifacts are occurring when subcatchments indicate the downstream node with the wrong case. SWMM handles these errors fine, but swmmnetwork does not.

fix initialization bug resulting in errors thrown if scenario loading is provided as load rather than as conc.

update unit conversion to match wqio.utils.normalize_units.

the method is to specify the lookup dictionary for specific common units (acre-ft, mg/L) and then add the factors that go to the common unit.

While iterating thorugh the nodes in line156 these can be mixed types. This causes line222 to fail if the node is an int.

This is ultimately an upstream issue with ScenarioLoading but I think that SwmmNetwork needs to also enforce string types so that if any([i in node for i in self.outfall_flags]) does not fail.

• SWMM Network Water Quality version:
• Python version:
• Operating System:

Description

Describe what you were trying to get done.
Tell us what happened, what went wrong, and what you expected to happen.

What I Did

Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.

edit the check() function to spit out the name of the offending element.

networks topological_sort fails when it encounters a cycle in a network, but the traceback is unhelpful in locating the offending links/nodes.

Add a try/except to catch the error (or find_cycle) and return the list of edges that are causing it.

Apparently SWMM5 doesn't care that the flow network is invalid.

need to improve modularity when building networks.