audigitalhealth / hotspot Goto Github PK

We're using quite an old version of Webpack, and some of our loaders and plugins are causing problems for security updates because of the old transitive dependencies they bring in to the bundle.

This task is to:

1. Update to the latest version of Webpack
2. Update all Webpack loaders and plugins
3. Make any necessary updates to the Webpack configuration
4. Refactor and simplify where appropriate

Currently, there is no way of correlating a deployed version of the software with a Git revision.

This could be implemented by adding a variable to the config.json, similar to Polecat: https://browse.medserve.online/config.json.

The way this is done in Polecat is by using Git to pass through the revision at HEAD in the dockerize script: https://github.com/AuDigitalHealth/polecat/blob/master/scripts/dockerize.sh#L3

Which is then picked up and put in an environment variable in the Dockerfile: https://github.com/AuDigitalHealth/polecat/blob/master/Dockerfile#L12

The new environment variable will need to be whitelisted in docker/buildConfig.sh.

Expected behaviour

• I expected Hotspot to render the requested resource

Actual behaviour

• I was presented with an error message, stating "Could not sniff format as either JSON or XML.". This is because the server returned a 304 response with an empty body. In this case Hotspot would need to load the cached response but it would appear not to at the moment

Steps to reproduce

• I think the server was actually incorrectly returning a 304 in this case but I guess it still needs to be handled. Not sure how to force the 304 locally.. however, on the problematic server clicking a link from an external source is enough to trigger it (ie. click a link posted in another application .... perhaps Slack?). The sample link is http://<INTERNAL_SERVER>/fhir/ValueSet/adverse-reaction-agent-1

Environment

• Problem occurring when opening URL in chrome from external application (implies that you cannot load without looking at the cache). Internal onto sandbox server

Currently, it is not obvious what type of resource you are viewing within Hotspot.

It would be good to show the current resource type somewhere on the UI, here's a wireframe:

We need a CircleCI build set up which will build and test Hotspot, as well as build the Docker image and push it to Docker Hub.

It would also be good to have a badge at the top of the README with the CircleCI build status.

Enable the automatic execution of the Circle CI build on branches that are the subject of a pull request.

The Docker image from a branch build should be tagged as the name of the branch and pushed to Docker Hub.