att / tegu Goto Github PK

The tegu_ha.py script does not properly handle the case where the "fqmgr" section does not have the phost_suffix defined. This is a legitmate case, and the value used if the pair is missing from the control file should be the same as if phost_suffix = "" were in the config file.

Relevant trace:

root@mtmac1:/var/log/tegu# cat tegu_ha.log
2015/09/08 14:23 tegu_ha v1.1 started
Traceback (most recent call last):
  File "/usr/bin/tegu_ha", line 408, in <module>
    main()
  File "/usr/bin/tegu_ha", line 367, in main
    if not cdata["fqmgr"]["phost_suffix"]:
KeyError: 'phost_suffix'

A blank line in the checkpoint file causes an out of bounds array check exception.

Corrected with commmit: e2216b4

The readme files for each branch need to be converted to markdown, and generally reviewed for accuracy and spelling.

The startup logic for tegu can pick the wrong checkpoint file to pass to Tegu if the last several checkpoint files were all created within the same second. For example, right now i have 28 checkpoint files, but on restart tegu started with resmgr_b26.ckpt. This is because they are sorted by mod time, and Linux only keeps modification times to a granularity of a second. Need a better way to arbitrate; either make sure each checkpoint is created within a unique 1 second period, or store metadata with each file to indicate millisecond granularity.

The tegu_ha.py script does not handle the case where a host name does not have an associated domain name (foo is returned instead of foo.somedom.com). The script needs properly handle this case.

Relevant trace:

2015/09/08 14:28 tegu_ha v1.1 started
Traceback (most recent call last):
  File "/usr/bin/tegu_ha", line 408, in <module>
    main()
  File "/usr/bin/tegu_ha", line 374, in main
    + this_node[this_node.index("."):])
ValueError: substring not found

The change to suss out new projects at the time a reservation request is made is causing an Openstack API call to be made which in some environments results in a 20 to 45 second block while Openstack processes. This call isn't necessary and should be removed.