atran2 / fureon Goto Github PK

I keep getting this when trying to python setup.py develop from scratch:

Searching for sqlalchemy
Best match: SQLAlchemy Utils-0.30.1
Downloading https://pypi.python.org/packages/source/S/SQLAlchemy-Utils/SQLAlchemy-Utils-0.30.1.tar.gz#md5=302bd66f6177230c7130782d891281f8
Processing SQLAlchemy-Utils-0.30.1.tar.gz

which isn't no sqlalchemy I ever heard of.

It seems to be fixed by running python setup.py develop again, though.

• test_get_random_song in test_song will fail randomly with probability approximately 8.5%.
• test_initialize_stream test_site_controls will occasionally fail the mock_run.called check. This is the result of a race condition between the time from when self.stream_player_watcher.start() is called, and when self.stream_player_watcher.run() is actually started. If the first thread gets to the mock_run.called check first, the test will fail. From testing, this appears to happen about 10% of the time.
  • Recommendation: maybe add a short (0.2s should work) time.sleep before the assert

Something nice-to-have.

May`n songs are pretty loud in comparison to the rest.

Chihaya (formerly Anzu) doesn't live on the same server as Fureon and so is being blocked by cross-origin protection. Please add the necessary CORS headers to server responses.

reference: http://www.html5rocks.com/en/tutorials/cors/#toc-adding-cors-support-to-the-server

copy paste solution:

Access-Control-Allow-Origin: *
Content-Type: text/html; charset=utf-8

If we go with cookie based authentication, you can use this instead:

Access-Control-Allow-Origin: *
Access-Control-Allow-Credentials: true
Content-Type: text/html; charset=utf-8