Git Product home page Git Product logo

linter-coffeelint's Introduction

Github Actions Dependencies

linter-coffeelint

This linter plugin for Linter provides an interface to coffeelint. It will be used with files that have the “CoffeeScript” or “CoffeeScript (literate)” syntax.

Installation

Linter or Atom IDE UI must be installed to use this plugin. To install Linter please follow the instructions here.

Plugin Installation

$ apm install linter-coffeelint

Settings

As of v0.2.0 there is no need to specify a path to coffeelint. If you need to use a specific version you can specify it in your project's package.json and linter-coffeelint will use that one. This is the same behavior the coffeelint commandline gives you.

How do I configure CoffeeLint?

Contributing

If you would like to contribute enhancements or fixes, please do the following:

  1. Fork the plugin repository.
  2. Hack on a separate topic branch created from the latest master.
  3. Commit and push the topic branch.
  4. Make a pull request.
  5. Welcome to the club 🎊

Please note that modifications must follow the ESLint configuration.

To check if the code complies, you may run:

$ npm run lint
  • Indent is 2 spaces.
  • Vertical whitespace helps readability, don’t be afraid to use it.

Thank you for helping out!

linter-coffeelint's People

Contributors

aki77 avatar arcanemagus avatar asaayers avatar dmnd avatar e-jigsaw avatar greenkeeper[bot] avatar greenkeeperio-bot avatar hd-deman avatar jetpackjarrett avatar keplersj avatar lijunle avatar pborreli avatar renovate-bot avatar renovate[bot] avatar semantic-release-bot avatar steelbrain avatar tekwiz avatar uzitech avatar vzamanillo avatar waffle-iron avatar walles avatar zimme avatar zolmeister avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

linter-coffeelint's Issues

Using linter-coffeelint with coffee-react-transform

I'm using coffee-react-transform with coffeelint. I have the following in my coffeelint.json file

  "coffeelint": {
    "transforms": [ "coffee-react-transform" ]
  }

This used to work before the most recent upgrade, but now I get the following error:

Error: Cannot find module 'coffee-react-transform'
  at Module._resolveFilename (module.js:351:15)
  at Function.Module._resolveFilename (/Applications/Atom.app/Contents/Resources/app/src/module-cache.js:383:52)
  at Function.Module._load (module.js:293:25)
  at Module.require (module.js:380:17)
  at require (module.js:399:17)
  at Object.module.exports.require (/Users/rich/.atom/packages/linter-coffeelint/node_modules/coffeelint/lib/ruleLoader.js:23:14)
  at Object.coffeelint.lint (/Users/rich/.atom/packages/linter-coffeelint/node_modules/coffeelint/lib/coffeelint.js:266:30)
  at LinterCoffeelint.lintFile (/Users/rich/.atom/packages/linter-coffeelint/lib/linter-coffeelint.coffee:49:25)
  at /Users/rich/.atom/packages/linter/lib/linter-view.coffee:158:18
  at Array.forEach (native)
  at /Users/rich/.atom/packages/linter/lib/linter-view.coffee:157:18
  at FSReqWrap.oncomplete (fs.js:100:15)

Bump coffeescript version?

I'm getting errors reported for valid code because the plugin uses an old version of coffeelint. Any chance we can get the version bumped to latest?

Current version: 1.5.2
Plugin uses version: ~1.2.0

Crashes if setting incorrect warning

CoffeLint will crash completely if one accidentally puts the wrong warning level int he lint configuration. the linter will throw an exception that will cause coffelint to crash.

Steps to Reproduce
Use warning instead of warn:

    "max_line_length": {
      "level": "warning",
      "value": 80
    }

Expected
An more user-friendly way to display the error based on the exception.

Does not work in Windows version of Atom

No errors, unsure if this is a coffeelint issue or an Atom issue

command and arguments ["c:\Users\Dranor.ELEMENTAL\.atom\packages\linter-coffeelint\node_modules\coffeelint\bin\coffeelint", "--reporter", "jslint", "c:\Users\DRANOR~1.ELE\AppData\Local\Temp\114617-13008-ivbxrksource.coffee"] - linter.coffee - line 68
is node executable: true - linter.coffee - line 91

Coffeelint config setting is ignored

The setting in Atom editor appears to be ignored as of 0.20 or 0.21.

screenshot 2015-03-31 19 34 07

Could you please either bring back support for the setting or remove it from the UI?

indent errors for config.cson

My config.cson for Atom gives a bunch of these (for each indentation):

Line contains inconsistent indentation. Expected 4 got 2. (Indentation)

screen shot 2016-06-13 at 1 07 25 am

My tab width is set to 2.

max_line_length setting ignored?

I get warnings about lines exceeding the maximum length. Those lines are longer than 80 characters though, and the default max_line_length should be 120 (in coffeelint.json). I did not overwrite it. I event tried adding it to ~/.atom/config.cson, but still no luck. Do I miss something here?

versions 0.2.x doesn't work with coffeelint-no-implicit-returns

Using Atom version 0.201 and [email protected] on OSX 10.10.2 with coffeelint-no-implicit-returns yields the following error:

Cannot find module 'coffeelint-no-implicit-returns' from 'file'
/Users/<username>/.atom/packages/linter-coffeelint/lib/linter-coffeelint.coffee:61 Error: Cannot find module 'coffeelint-no-implicit-returns' from 'file'
  at module.exports (/Users/<username>/.atom/packages/linter-coffeelint/node_modules/coffeelint/node_modules/resolve/lib/sync.js:32:11)
  at expandModuleNames (/Users/<username>/.atom/packages/linter-coffeelint/node_modules/coffeelint/lib/configfinder.js:78:35)
  at Object.exports.getConfig (/Users/<username>/.atom/packages/linter-coffeelint/node_modules/coffeelint/lib/configfinder.js:111:16)
  at LinterCoffeelint.lintFile (/Users/<username>/.atom/packages/linter-coffeelint/lib/linter-coffeelint.coffee:49:29)
  at /Users/<username>/.atom/packages/linter/lib/linter-view.coffee:163:18
  at Array.forEach (native)
  at /Users/<username>/.atom/packages/linter/lib/linter-view.coffee:162:18
  at FSReqWrap.oncomplete (fs.js:77:15)

Workaround is downgrading to [email protected]

coffeelint executable path incorrect

When I do which coffeelint I get /usr/bin/coffeelint as the output. So, I set the coffeelint executable path to /usr/bin/coffeelint, but then I get the error: Error: Cannot find module '/usr/bin/coffeelint/coffeelint'.

I can fix this by setting the executable path to /usr/bin, but then it's not really the "executable path"... it's the path to the directory that holds the executable.

Allow inline errors to be disabled

I just upgraded my version to 1.1.0 and now I've got these really annoying inline errors:

These bother me a lot because they popup before I'm even done writing the whole line! Didn't there used to be an option in the config to turn these off and only have footer/line-number-gutter errors?

Error Thrown: ReferenceError: findFile is not defined

On launch of any coffeescript file I get the stacktrace -

editorView.editor.getGrammar().scopeNamesource.coffee init.coffee:35
ReferenceError: findFile is not defined
  at new LinterCoffeelint (/Users/adambutler/.atom/packages/linter-coffeelint/lib/linter-coffeelint.coffee:26:14)
  at LinterView.initLinters (/Users/adambutler/.atom/packages/linter/lib/linter-view.coffee:50:27)
  at new LinterView (/Users/adambutler/.atom/packages/linter/lib/linter-view.coffee:27:6)
  at Object.module.exports.injectLinterViewIntoEditorView (/Users/adambutler/.atom/packages/linter/lib/init.coffee:36:22)
  at /Users/adambutler/.atom/packages/linter/lib/init.coffee:25:21
  at HTMLDivElement.attachedCallback (/Applications/Atom.app/Contents/Resources/app/src/workspace-view.js:479:18)
  at HTMLDivElement.jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4676:9)
  at HTMLDivElement.elemData.handle (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4360:28)
  at Object.jQuery.event.trigger (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4594:12)
  at HTMLDivElement.<anonymous> (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:5119:17)
  at Function.jQuery.extend.each (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:590:23)
  at EditorView.jQuery.fn.jQuery.each (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:237:17)
  at EditorView.jQuery.fn.extend.trigger (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:5118:15)
  at EditorView.module.exports.EditorView.afterAttach (/Applications/Atom.app/Contents/Resources/app/src/editor-view.js:1083:19)
  at callAttachHook (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/lib/space-pen.js:323:107)
  at [object Object].jQuery.fn.(anonymous function) [as append] (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/lib/space-pen.js:339:9)
  at PaneView.module.exports.PaneView.onActiveItemChanged (/Applications/Atom.app/Contents/Resources/app/src/pane-view.js:293:24)
  at /Applications/Atom.app/Contents/Resources/app/src/pane-view.js:3:61
  at /Applications/Atom.app/Contents/Resources/app/node_modules/emissary/lib/emitter.js:133:30
  at Array.forEach (native)
  at Behavior.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app/node_modules/emissary/lib/emitter.js:132:47)
  at Behavior.module.exports.Behavior.emit (/Applications/Atom.app/Contents/Resources/app/node_modules/emissary/lib/behavior.js:44:38)
  at Behavior.module.exports.Signal.emitValue (/Applications/Atom.app/Contents/Resources/app/node_modules/emissary/lib/signal.js:82:19)
  at Pane.module.exports.Model.set (/Applications/Atom.app/Contents/Resources/app/node_modules/theorist/lib/model.js:166:21)
  at Pane.accessor.set (/Applications/Atom.app/Contents/Resources/app/node_modules/theorist/lib/model.js:57:23)
  at Pane.module.exports.Pane.addItem (/Applications/Atom.app/Contents/Resources/app/src/pane.js:189:25)
  at Pane.module.exports.Pane.activateItem (/Applications/Atom.app/Contents/Resources/app/src/pane.js:174:14)
  at /Applications/Atom.app/Contents/Resources/app/src/workspace.js:214:16
  at _fulfilled (/Applications/Atom.app/Contents/Resources/app/node_modules/q/q.js:787:54)
  at self.promiseDispatch.done (/Applications/Atom.app/Contents/Resources/app/node_modules/q/q.js:816:30)
  at Promise.promise.promiseDispatch (/Applications/Atom.app/Contents/Resources/app/node_modules/q/q.js:749:13)
  at /Applications/Atom.app/Contents/Resources/app/node_modules/q/q.js:557:44
  at flush (/Applications/Atom.app/Contents/Resources/app/node_modules/q/q.js:108:17)
  at process._tickCallback (node.js:605:11)

How to use coffeelint modules?

Hello,

i want to use the coffeescope2 plugin with coffeelint. If i install coffeelint and coffeescope2 in the global namespace and add the coffeescope2 configuration to the coffeelint.json, coffeelint crashes with the following error:

Error: Cannot find module 'coffeescope2' from ...

coffeelint.json:

 "check_scope": {
   "module": "coffeescope2",
 ...

Thanks for your help!

CJSX not supported

I use CoffeeScript with the React library. So I use CJSX files. Unfortunately I get following error:

screenshot

An in-range update of eslint is breaking the build 🚨

Version 3.10.1 of eslint just got published.

Branch Build failing 🚨
Dependency eslint
Current Version 3.10.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪


Status Details
  • ci/circleci Your tests failed on CircleCI Details
Commits

The new version differs by 4 commits .

  • 9cbfa0b 3.10.1
  • 4bb6215 Build: package.json and changelog update for 3.10.1
  • 8a0e92a Fix: handle try/catch correctly in no-return-await (fixes #7581) (#7582)
  • c4dd015 Fix: no-useless-return stack overflow on unreachable loops (fixes #7583) (#7584)

See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

False positive on modern Coffeescript syntax

Current version is based on a version of coffeelint which is over a year old. Quoting the coffeelint changelog:

The v1.12.x versions are considered buggy and you should upgrade to v1.13.x if you experience problems

In addition to that, modern syntax (import/export, generators and others), as well as new lint rules aren't supported.

#68 fixes that! :)

Automatically toggle results panel

Thank you for this really nice package! It would be nice though if, on save, the results panel could automatically be opened if any errors are present.

What happened to the error/warning summary?

In an older version of Atom w/ this plugin there used to be a summary of all the errors an warnings for a file. This was superb with little effort needed to navigate a file and find the problems.

Anyway since 1.0.0 or maybe 1.1.0 the summary box has disappeared. Is there anyway to bring this back via settings? Is this a regression due Atom updates.. I just wanted to throw this out there as this feature was awesome and sorely missed.

Wrong Path supplied to coffeelint/lib/configfinder.js

I've discovered an issue when working on coffee files that are in the same directory as the coffeelint.json/package.json file that contains the definition coffeelint configuration. The plugin currently supplies the parent directory of the current file to the configfinder supplied by coffeelint.

However this will cause it to not find the correct file (and return null). To fix the issue you can change the parameter supplied to the finder to filePath rather than origPath on line 68 of core.coffee:

config = configFinder.getConfig(filePath)

Whilst this use case isn't like to occur often. It is a problem in the case where I am using coffeescript to write my Gulpfile.

max_line_length can't ignore

I use v0.2.1.
I set below setting in coffeelint.json

  "max_line_length": {
    "name": "max_line_length",
    "level": "ignore"
  },

But it also show max_line_length message.

Failed to activate the linter-coffeelint package

[Enter steps to reproduce below:]

  1. ...
  2. ...

Atom Version: 1.0.19
System: Mac OS X 10.11
Thrown From: linter-coffeelint package, v1.1.2

Stack Trace

Failed to activate the linter-coffeelint package

At Cannot find module 'atom-package-deps'

Error: Cannot find module 'atom-package-deps'
    at Module._resolveFilename (module.js:334:15)
    at Function.Module._resolveFilename (/Applications/Atom.app/Contents/Resources/app.asar/src/module-cache.js:383:52)
    at Function.Module._load (module.js:284:25)
    at Module.require (module.js:363:17)
    at require (module.js:382:17)
    at Object.module.exports.activate (/Users/zerozodix/.atom/packages/linter-coffeelint/lib/init.coffee:13:5)
    at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:245:19)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:226:30
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:169:15)
    at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:218:14)

Commands

Config

{
  "core": {
    "disabledPackages": [
      "coffee-refactor",
      "refactor"
    ]
  }
}

Installed Packages

# User
angularjs, v0.3.3
go-plus, v3.5.1
linter, v1.8.1
linter-coffeelint, v1.1.2
vim-mode, vundefined

# Dev
No dev packages

Update Settings section in README.md?

Great plugin, thanks! Following the link in the Settings section of your README, I had been putting my coffeelint.json file in my project, which definitely has its uses for teams, but I wanted a global config to suit my own tastes. Maybe you should note that that you can also put your personal preferences in

~/.atom/packages/linter-coffeelint/node_modules/coffeelint/coffeelint.json

(on mac at least). That way coffee-lint will use these preferences when linting...

Object.activate is deprecated.

AtomLinter v0.X.Y API has been deprecated. Please refer to the Linter docs to update and the latest API: https://github.com/AtomLinter/Linter/wiki/Migrating-to-the-new-API

Object.activate (/home/steel/.atom/packages/linter/lib/main.coffee:51:8)
Package.activateNow (/usr/share/atom/resources/app.asar/src/package.js:238:19)
<unknown> (/usr/share/atom/resources/app.asar/src/package.js:219:30)
Package.measure (/usr/share/atom/resources/app.asar/src/package.js:163:15)
Package.activate (/usr/share/atom/resources/app.asar/src/package.js:211:14)
PackageManager.activatePackage (/usr/share/atom/resources/app.asar/src/package-manager.js:452:21)

.coffeelintignore is ignored :P

Please pay attention to .coffeelintignore. The coffeescript linter itself won't since it (correctly, IMO) will lint any file that you explicitly tell it to, as is the case here.

An in-range update of eslint is breaking the build 🚨

Version 3.12.1 of eslint just got published.

Branch Build failing 🚨
Dependency eslint
Current Version 3.12.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪


Status Details
  • ci/circleci A command timed out during your tests Details
Release Notes v3.12.1
  • 0ad4d33 Fix: indent regression with function calls (fixes #7732, fixes #7733) (#7734) (Teddy Katz)
  • ab246dd Docs: Rules restricting globals/properties/syntax are linked together (#7743) (Kevin Partington)
  • df2f115 Docs: Add eslint-config-mdcs to JSCS Migration Guide (#7737) (Joshua Koo)
  • 4b77333 Build: avoid creating broken rule links in the changelog (#7731) (Teddy Katz)
Commits

The new version differs by 6 commits .

  • 9679daa 3.12.1
  • 8a31bc8 Build: package.json and changelog update for 3.12.1
  • 0ad4d33 Fix: indent regression with function calls (fixes #7732, fixes #7733) (#7734)
  • ab246dd Docs: Rules restricting globals/properties/syntax are linked together (#7743)
  • df2f115 Docs: Add eslint-config-mdcs to JSCS Migration Guide (#7737)
  • 4b77333 Build: avoid creating broken rule links in the changelog (#7731)

See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

Uncaught TypeError: Cannot read property 'coffeelintConfig' of null

[Enter steps to reproduce below:]

  1. ...
  2. ...

Atom Version: 0.187.0
System: Mac OS X 10.10.3
Thrown From: linter-coffeelint package, v0.2.0

Stack Trace

Uncaught TypeError: Cannot read property 'coffeelintConfig' of null

At /Users/dmitry/.atom/packages/linter-coffeelint/node_modules/coffeelint/lib/configfinder.js:37

TypeError: Cannot read property 'coffeelintConfig' of null
  at loadNpmConfig (/Users/dmitry/.atom/packages/linter-coffeelint/node_modules/coffeelint/lib/configfinder.js:37:26)
  at Object.exports.getConfig (/Users/dmitry/.atom/packages/linter-coffeelint/node_modules/coffeelint/lib/configfinder.js:62:17)
  at LinterCoffeelint.lintFile (/Users/dmitry/.atom/packages/linter-coffeelint/lib/linter-coffeelint.coffee:46:27)
  at /Users/dmitry/.atom/packages/linter/lib/linter-view.coffee:158:18
  at Array.forEach (native)
  at /Users/dmitry/.atom/packages/linter/lib/linter-view.coffee:157:18
  at FSReqWrap.oncomplete (fs.js:100:15)

Commands

  3x -1:13.1 core:move-down (atom-text-editor.editor.is-focused)
     -1:10.9 editor:delete-to-beginning-of-line (atom-text-editor.editor.is-focused)
     -1:10.5 core:backspace (atom-text-editor.editor.is-focused)
  2x -1:07.9 core:paste (atom-text-editor.editor.is-focused)
     -0:54.1 editor:delete-to-beginning-of-word (atom-text-editor.editor.is-focused)
     -0:53.8 core:backspace (atom-text-editor.editor.is-focused)
     -0:52.0 core:copy (atom-text-editor.editor.is-focused)
  7x -0:49.3 core:undo (atom-text-editor.editor.is-focused)
 14x -0:43.5 core:redo (atom-text-editor.editor.is-focused)
     -0:38.6 core:paste (atom-text-editor.editor.is-focused)
  7x -0:38.2 core:backspace (atom-text-editor.editor.is-focused)
     -0:36.8 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -0:36.8 core:cancel (atom-text-editor.editor.is-focused)
  2x -0:36.0 core:save (atom-text-editor.editor.is-focused)
     -0:33.8 core:close (atom-text-editor.editor.is-focused)
  2x -0:06.3 core:backspace (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "ignoredNames": [
      ".git",
      ".svn",
      ".DS_Store",
      ".pyc"
    ],
    "projectHome": "~/code",
    "disabledPackages": [
      "atom-ctags"
    ],
    "followSymlinks": true,
    "themes": [
      "one-dark-ui",
      "monokai"
    ]
  },
  "linter-coffeelint": {}
}

Installed Packages

# User
Sublime-Style-Column-Selection, v1.2.3
atom-beautify, v0.23.1
atom-jinja2, v0.5.0
autocomplete-paths, v1.0.2
autocomplete-plus, v2.7.0
color-picker, v1.5.0
editorconfig, v0.3.3
file-icons, v1.5.2
highlight-line, v0.10.1
highlight-selected, v0.9.1
language-docker, v1.1.3
linter, v0.12.0
linter-coffeelint, v0.2.0
linter-flake8, v1.3.0
linter-scss-lint, v0.0.14
monokai, v0.13.0
open-last-project, v0.3.5
project-manager, v1.15.5
regex-railroad-diagram, v0.7.1
revert-buffer, v0.5.0
welcome, v0.26.0

# Dev
No dev packages

Uncaught TypeError: Cannot read property '0' of null

[Enter steps to reproduce below:]

  1. Open your user configuration in Atom
  2. Observe error (although it may be dependent on the config itself)

Atom Version: 0.188.0
System: Mac OS X 10.10.2
Thrown From: linter-coffeelint package, v0.2.0

Stack Trace

Uncaught TypeError: Cannot read property '0' of null

At /Users/jfitzgerald/.atom/packages/linter-coffeelint/node_modules/coffeelint/lib/coffeelint.js:2039

TypeError: Cannot read property '0' of null
  at NoImplicitBraces.module.exports.NoImplicitBraces.lintToken (/Users/jfitzgerald/.atom/packages/linter-coffeelint/node_modules/coffeelint/lib/coffeelint.js:2039:42)
  at LexicalLinter.module.exports.LexicalLinter.lintToken (/Users/jfitzgerald/.atom/packages/linter-coffeelint/node_modules/coffeelint/lib/coffeelint.js:818:43)
  at LexicalLinter.module.exports.LexicalLinter.lint (/Users/jfitzgerald/.atom/packages/linter-coffeelint/node_modules/coffeelint/lib/coffeelint.js:786:19)
  at Object.coffeelint.lint (/Users/jfitzgerald/.atom/packages/linter-coffeelint/node_modules/coffeelint/lib/coffeelint.js:311:31)
  at LinterCoffeelint.lintFile (/Users/jfitzgerald/.atom/packages/linter-coffeelint/lib/linter-coffeelint.coffee:49:25)
  at /Users/jfitzgerald/.atom/packages/linter/lib/linter-view.coffee:158:18
  at Array.forEach (native)
  at /Users/jfitzgerald/.atom/packages/linter/lib/linter-view.coffee:157:18
  at FSReqWrap.oncomplete (fs.js:100:15)

Commands

     -7:59.6 settings-view:open (atom-text-editor.editor)
     -7:51.0 core:copy (atom-text-editor.editor)

Config

{
  "core": {
    "disabledPackages": [
      "atom-beautify",
      "markdown-format"
    ],
    "themes": [
      "atom-dark-ui",
      "solarized-dark-syntax"
    ]
  },
  "linter-coffeelint": {
    "coffeelintExecutablePath": "/usr/local/bin/coffeelint"
  }
}

Installed Packages

# User
autocomplete-paths, v1.0.2
autocomplete-plus, v2.7.1
autocomplete-snippets, v1.2.0
go-plus, v3.3.1
language-asciidoc, v0.11.1
language-docker, v1.1.3
language-tcl, v0.1.0
linter, v0.12.0
linter-coffeelint, v0.2.0
markdown-table-formatter, v2.5.2
pretty-json, v0.3.2
tabs-to-spaces, v0.9.1

# Dev
autocomplete-paths, v1.0.2
autocomplete-plus, v2.7.1
autocomplete-snippets, v1.0.1
go-plus, v3.3.1

Does not search in node_modules to find the appropriate modules

I added some additional modules to the coffeelint.json like:

"no_trailing_commas": {
    "module": "coffeelint-no-trailing-commas",
    "level": "error"
  },

I have the plugin installed and visible in the node_modules folder of the project.

When I open one of the files in my project there is a crash in the console. The linter-coffee plugin does not search in the node_modules folder, I don't know if it expects me to install the plugin globally.

This is the error I get:

Cannot find module 'coffeelint-no-trailing-commas' from '/home/joro/WorkSpace/getti/js/clover-be/src/routes'
/home/joro/.atom/packages/linter-coffeelint/lib/core.coffee:91 Error: Cannot find module 'coffeelint-no-trailing-commas' from '/home/joro/WorkSpace/getti/js/clover-be/src/routes'
  at module.exports (/home/joro/WorkSpace/getti/js/clover-be/node_modules/resolve/lib/sync.js:32:11)
  at expandModuleNames (/home/joro/WorkSpace/getti/js/clover-be/node_modules/coffeelint/lib/configfinder.js:84:33)
  at Object.exports.getConfig (/home/joro/WorkSpace/getti/js/clover-be/node_modules/coffeelint/lib/configfinder.js:137:16)
  at Object.module.exports.lint (/home/joro/.atom/packages/linter-coffeelint/lib/core.coffee:79:29)
  at _Class.module.exports._Class.lint (/home/joro/.atom/packages/linter-coffeelint/lib/plus-linter.coffee:43:19)
  at _Class.lint (/home/joro/.atom/packages/linter-coffeelint/lib/plus-linter.coffee:1:1)
  at promises.push.Promise.then._this.emitter.emit.linter (/home/joro/.atom/packages/linter/lib/linter-registry.js:95:28)
  at /home/joro/.atom/packages/linter/lib/linter-registry.js:94:25
  at Set.forEach (native)
  at LinterRegistry.lint (/home/joro/.atom/packages/linter/lib/linter-registry.js:92:20)
  at /home/joro/.atom/packages/linter/lib/linter.coffee:98:16
  at Function.module.exports.Emitter.simpleDispatch (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
  at Emitter.module.exports.Emitter.emit (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
  at /home/joro/.atom/packages/linter/lib/editor-linter.js:100:23
  at /home/joro/.atom/packages/linter/lib/helpers.coffee:23:18

An in-range update of eslint is breaking the build 🚨

Version 3.12.0 of eslint just got published.

Branch Build failing 🚨
Dependency eslint
Current Version 3.11.1
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪


Status Details
  • ci/circleci A command timed out during your tests Details
Release Notes v3.12.0
  • e569225 Update: fix false positive/negative of yoda rule (fixes #7676) (#7695) (Toru Nagashima)
  • e95a230 Fix: indent "first" option false positive on nested arrays (fixes #7727) (#7728) (Teddy Katz)
  • 81f9e7d Fix: Allow duplicated let declarations in prefer-const (fixes #7712) (#7717) (Teddy Katz)
  • 1d0d61d New: Add no-await-in-loop rule (#7563) (Nat Mote)
  • 2cdfb4e New: Additional APIs (fixes #6256) (#7669) (Ilya Volodin)
  • 4278c42 Update: make no-obj-calls report errors for Reflect (fixes #7700) (#7710) (Tomas Echeverri Valencia)
  • 4742d82 Docs: clarify the default behavior of operator-linebreak (fixes #7459) (#7726) (Teddy Katz)
  • a8489e2 Chore: Avoid parserOptions boilerplate in tests for ES6 rules (#7724) (Teddy Katz)
  • b921d1f Update: add indent options for array and object literals (fixes #7473) (#7681) (Teddy Katz)
  • 7079c89 Update: Add airbnb-base to init styleguides (fixes #6986) (#7699) (alberto)
  • 63bb3f8 Docs: improve the documentation for the autofix API (#7716) (Teddy Katz)
  • f8786fb Update: add fixer for capitalized-comments (#7701) (Teddy Katz)
  • abfd24f Fix: don't validate schemas for disabled rules (fixes #7690) (#7692) (Teddy Katz)
  • 2ac07d8 Upgrade: Update globals dependency to 9.14.0 (#7683) (Aleksandr Oleynikov)
  • 90a5d29 Docs: Remove incorrect info about issue requirements from PR guide (#7691) (Teddy Katz)
  • f80c278 Docs: Add sails-hook-lint to integrations list (#7679) (Anthony M)
  • e96da3f Docs: link first instance of package.json (#7684) (Kent C. Dodds)
  • bf20e20 Build: include links to rule pages in release blogpost (#7671) (Teddy Katz)
  • b30116c Docs: Fix code-blocks in spaced-comment docs (#7524) (Michał Gołębiowski)
  • 0a2a7fd Fix: Allow \u2028 and \u2029 as string escapes in no-useless-escape (#7672) (Teddy Katz)
  • 76c33a9 Docs: Change Sails.js integration to active npm package (#7675) (Anthony M)
Commits

The new version differs by 23 commits .

  • da79f17 3.12.0
  • 519e790 Build: package.json and changelog update for 3.12.0
  • e569225 Update: fix false positive/negative of yoda rule (fixes #7676) (#7695)
  • e95a230 Fix: indent "first" option false positive on nested arrays (fixes #7727) (#7728)
  • 81f9e7d Fix: Allow duplicated let declarations in prefer-const (fixes #7712) (#7717)
  • 1d0d61d New: Add no-await-in-loop rule (#7563)
  • 2cdfb4e New: Additional APIs (fixes #6256) (#7669)
  • 4278c42 Update: make no-obj-calls report errors for Reflect (fixes #7700) (#7710)
  • 4742d82 Docs: clarify the default behavior of operator-linebreak (fixes #7459) (#7726)
  • a8489e2 Chore: Avoid parserOptions boilerplate in tests for ES6 rules (#7724)
  • b921d1f Update: add indent options for array and object literals (fixes #7473) (#7681)
  • 7079c89 Update: Add airbnb-base to init styleguides (fixes #6986) (#7699)
  • 63bb3f8 Docs: improve the documentation for the autofix API (#7716)
  • f8786fb Update: add fixer for capitalized-comments (#7701)
  • abfd24f Fix: don't validate schemas for disabled rules (fixes #7690) (#7692)

There are 23 commits in total. See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

Not working with coffeelint.json in project's root

It seem that linter is not working at all if I have a local configuration in my project's root.
Without one, it works, but by just copying the default configuration in my project it stops working.
Any ideas?

env: node: No such file or directory

coffeelint is failing for me in Atom 0.100.0 on OS X 10.9 with

linter: run commands
linter: run linter command
/Users/johannes/.atom/packages/linter-coffeelint/node_modules/coffeelint/bin/coffeelint --jslint /var/folders/_n/3c7_c11j7xlctv0jxt3lntyh0000gn/T/114430-2276-1v1jge0source.coffee
/Users/johannes/Documents/dashboard/test/integration
env: node: No such file or directory

It seems that the atom bundled node wasn't found.

Exception for URLs going to end of line with `max_line_length`?

I know other linters (such as markdown) forgive max lines which exceed the designated amount as long as it is due to a URL at the end of a line (with nothing after it).

Could support for this be added, as I need a long URL in the comments...

Thanks!

Invalid Linter: grammarScopes is not an Array. (see console for more info)

Just updated from 0.3.0 to 1.0.0, and this error got thrown:

Error: grammarScopes is not an Array. (see console for more info)
  at Object.module.exports.validateLinter (/Users/machistequintana/.atom/packages/linter/lib/helpers.coffee:19:17)
  at Linter.addLinter (/Users/machistequintana/.atom/packages/linter/lib/linter-plus.coffee:46:18)
  at Object.module.exports.consumeLinter (/Users/machistequintana/.atom/packages/linter/lib/main.coffee:62:17)
  at Provider.module.exports.Provider.provide (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/service-hub/lib/provider.js:30:34)
  at ServiceHub.module.exports.ServiceHub.provide (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/service-hub/lib/service-hub.js:29:18)
  at Package.module.exports.Package.activateServices (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:372:65)
  at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:243:16)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:221:30
  at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:165:15)
  at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:213:14)
  at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:452:21)
  at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/settings-view/lib/package-manager.js:306:60
  at exit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/settings-view/lib/package-manager.js:53:16)
  at triggerExitCallback (/Applications/Atom.app/Contents/Resources/app.asar/src/buffered-process.js:213:47)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/buffered-process.js:227:18
  at Socket.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/buffered-process.js:98:18)
  at emitOne (events.js:82:20)
  at Socket.emit (events.js:166:7)
  at Pipe.close (net.js:464:12)
  1. Open Settings View
  2. Go to the Updates panel
  3. Click the Update button for linter-coffeelint
  4. When it finishes installing, this error is thrown

If it helps, I had a .coffee file open in another tab when I updated the linter, so maybe that's what was going on here?

coffeelint.json being ignored with symlinked files

Hello there,
there are numerous issues where the coffeelint.json isn't recognized.
I've got a similar issue, but the folder with my coffeescript files is symlinked into my project folder.
The coffeelint.json is in the project folder.

62fa7f9e-1e52-11e5-9a2d-2e419b229ed9

Implement specs

It looks like this linter does not currently have any specs written for it, adding it to the list being maintained here for tracking.

Specs do not need to be super detailed, as they should mainly test whether the package is properly running the linter plugin and parsing its messages. Leave testing of the linter functionality to the author of the linter.

If you need any help feel free to ask!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.