Add a check for unknown responses that don't match the current regex.

Setting up a brand new repo:

lein new myproject

I get this error on project.clj

Unable to resolve symbol: defproject in this context

I'm using Clojure 1.8.0. Any suggestions?

It looks like this linter does not currently have any specs written for it, adding it to the list being maintained here for tracking.

Specs do not need to be super detailed, as they should mainly test whether the package is properly running the linter plugin and parsing its messages. Leave testing of the linter functionality to the author of the linter.

If you need any help feel free to ask!

By using atom-package-deps you are able to install linter automatically on activation. This will allow new Atom users to install only your package and nothing else, removing one step from the installation process.

Please see AtomLinter/linter-ruby#38 for example.

Config::unobserve no longer does anything. Call .dispose() on the object returned by Config::observe instead.

Config.unobserve (/Applications/Atom.app/Contents/Resources/app/src/config.js:1045:19)
LinterClojure.destroy (/Users/requnix/.atom/packages/linter-clojure/lib/linter-clojure.coffee:33:16)

Config.unobserve (/Applications/Atom.app/Contents/Resources/app/src/config.js:1045:19)
LinterClojure.destroy (/Users/requnix/.atom/packages/linter-clojure/lib/linter-clojure.coffee:34:16)

Use a config schema instead. See the configuration section
of https://atom.io/docs/latest/hacking-atom-package-word-count and
https://atom.io/docs/api/latest/Config for more details

Package.activateConfig (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:247:11)
Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:218:14)
<unknown> (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:203:30)
Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:147:15)

Description

The problem seems to affect the linter only when used with linter-clojure (or other JVM-based languages linters). When no error is detected by the linter (thus leading to an empty stderr), an "Unknown error. The process terminated with no output. Error code: 0" message is shown [1] in Developers Tools Console and from now on the linter stops working until an error in the code is detected [2], and stderr populated. If, afterwards, no error is present in the code and the linter is triggered, still the linter shows the last non-empty stderr content [3]. The linter's functionality is therefore disrupted.

Reproducibility: 100%

Steps to reproduce

After the linter is installed...

1. Open (or create new file, then save it) a .clj file with obviously bugless code in it, i.e.:

(+ 1 2 3)

2. Save it, so as to trigger the linting process. Case [1] ensues.
3. Add code with errors i.e.:

(+ 1 2 3)
xyz

4. Save it, so as to trigger the linting process. An error at line 2 is detected "Cannot resolve xyz", but the linter itself works properly (case [2]).
5. Remove the buggy line:

(+ 1 2 3)
xyz

6. Save it, so as to trigger the linting process. Still, an error at line 2 is detected "Cannot resolve xyz", the the linter itself works properly but there's not even a line 2 (case [3]).

Suggested fix

See pull #55

Versions

OS : Ubuntu 16.04, fully updated
Atom install method : Official DEB package from https://atom.io/
AtomLinter and linter-clojure install method : From inside Atom, Packages section
linter version : 2.2.0 (steelbrain)
linter-clojure version : 1.1.3

• Output of atom --version :

Atom    : 1.19.3
Electron: 1.6.9
Chrome  : 56.0.2924.87
Node    : 7.4.0

• Output of apm --version :

apm  1.18.4
npm  3.10.10
node 6.9.5 x64
python 2.7.13
git 2.14.1

Version 4.14.0 of eslint was just published.

This version is covered by your current version range and after updating it in your project the build failed.

eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Version 2.9.0 of eslint-plugin-import was just published.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-import is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update eslint packages (eslint-config-airbnb-base, eslint-plugin-import)
• chore(deps): update eslint packages (major) (eslint, eslint-config-airbnb-base)
• fix(deps): update dependency atom-package-deps to v8
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Version 4.6.1 of atom-package-deps was just published.

This version is covered by your current version range and after updating it in your project the build failed.

atom-package-deps is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

I get an error

(ns view.product-box
  (:require-macros [cljs.core.async.macros :refer [go]])
  (:require
    [rum.core :as rum :include-macros true]
    [clj-di.core :as di :refer-macros [let-deps]]
    [cljs.core.async :as async :refer [<!]]
    [view.core :as v]
    [core.util :as u]
    [view.ui :as ui]
    [sablono.core :refer-macros [html]]
    [clojure.string :as string]))

This code is valid.

Would it be simple to modify this plugin to support ClojureScript as well?

lintOnFly should be set to false, this linter only operates on the file contents on disk.

If this linter supports stdin input, then modify this package to use that and leave lintOnFly enabled.

[Enter steps to reproduce below:]

1. ...
2. ...

Atom Version: 1.0.11
System: Ubuntu 15.04
Thrown From: linter-clojure package, v1.0.0

Stack Trace

Uncaught Error: spawn EACCES

At /usr/share/atom/resources/app.asar/src/buffered-process.js:260

Error: spawn EACCES
  at exports._errnoException (util.js:734:11)
  at ChildProcess.spawn (child_process.js:1145:11)
  at Object.exports.spawn (child_process.js:977:9)
  at BufferedProcess.module.exports.BufferedProcess.spawn (/usr/share/atom/resources/app.asar/src/buffered-process.js:188:44)
  at new BufferedProcess (/usr/share/atom/resources/app.asar/src/buffered-process.js:52:14)
  at /home/justcxx/.atom/packages/linter-clojure/node_modules/atom-linter/lib/helpers.coffee:45:30
  at Object.module.exports.Helpers._exec (/home/justcxx/.atom/packages/linter-clojure/node_modules/atom-linter/lib/helpers.coffee:25:16)
  at Object.module.exports.Helpers.exec (/home/justcxx/.atom/packages/linter-clojure/node_modules/atom-linter/lib/helpers.coffee:16:13)
  at Object.provider.lint (/home/justcxx/.atom/packages/linter-clojure/lib/init.coffee:27:24)
  at Promise.then._this.emitter.emit.linter (/home/justcxx/.atom/packages/linter/lib/linter-registry.coffee:59:22)
  at LinterRegistry.triggerLinter (/home/justcxx/.atom/packages/linter/lib/linter-registry.coffee:58:16)
  at /home/justcxx/.atom/packages/linter/lib/linter-registry.coffee:52:17
  at Array.map (native)
  at /home/justcxx/.atom/packages/linter/lib/linter-registry.coffee:50:27

Commands

     -0:03.6.0 command-palette:toggle (atom-text-editor.editor.is-focused)
     -0:01.3.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:01.3.0 linter:lint (atom-text-editor.editor)

Config

{
  "core": {
    "disabledPackages": [
      "bookmarks",
      "language-csharp",
      "language-perl",
      "language-objective-c",
      "welcome",
      "linter-xmllint",
      "linter-cpplint",
      "color-picker",
      "git-blame",
      "git-log",
      "linter-php",
      "linter-pylint",
      "linter-jscs",
      "linter-clang",
      "linter-ruby"
    ]
  },
  "linter-clojure": {
    "clojureExecutablePath": "/home/justcxx/.m2/repository/org/clojure/clojure/1.7.0/clojure-1.7.0.jar",
    "javaExecutablePath": "/usr/bin"
  }
}

Installed Packages

# User
asciidoc-preview, v0.6.0
file-icons, v1.6.9
git-diff-details, v0.20.0
language-scheme, v1.4.0
linter, v1.5.0
linter-clojure, v1.0.0
linter-erb, v0.1.1
linter-eslint, v3.0.2
linter-js-yaml, v1.1.1
linter-rubocop, v0.3.4
regex-railroad-diagram, v0.8.4
ruby-block, v0.3.5
ruby-block-converter, v3.5.0
svg-preview, v0.6.1
tree-view-git-status, v0.2.0
zentabs, v0.8.6

# Dev
No dev packages

Use activationCommands instead of activationEvents in your package.json
Commands should be grouped by selector as follows:

  "activationCommands": {
    "atom-workspace": ["foo:bar", "foo:baz"],
    "atom-text-editor": ["foo:quux"]
  }

Package.getActivationCommands (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:790:9)
Package.hasActivationCommands (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:715:20)
<unknown> (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:169:24)
Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:147:15)

Specifying the java 'bin' path does not work. Given the following setup, I get the error shown below.

  "linter-clojure":
    clojureExecutablePath: "/Users/trevershick/.m2/repository/org/clojure/clojure/1.6.0/clojure-1.6.0.jar"
    javaExecutablePath: "/usr/bin"

Once I changed it to the following (notice the '/java'), it all worked fine.

  "linter-clojure":
    clojureExecutablePath: "/Users/trevershick/.m2/repository/org/clojure/clojure/1.6.0/clojure-1.6.0.jar"
    javaExecutablePath: "/usr/bin/java"

After a little exploration, I believe the reason linter-clojure fails to lint certain files correctly is because the command it constructs fails to include all classpaths required to properly compile the source.

For example, if I attempt to lint a file that has (:require [foo :a f]), the compilation will error with:

Exception in thread "main" java.io.FileNotFoundException: Could not locate foo/core__init.class or foo/core.clj on classpath: , compiling:(.../source.clj:1:1)

which will halt compilation before syntactic errors can be detected.

The only way I can imagine to remediate this error would be to call a clojure syntax checker rather than relying on java to compile the file.

[Enter steps to reproduce below:]

1. Set configs
2. Restart

Atom Version: 1.2.3
System: Mac OS X 10.11.1
Thrown From: linter-clojure package, v1.1.0

Stack Trace

Failed to activate the linter-clojure package

At require(...)(...)[1].getFileName is not a function

TypeError: require(...)(...)[1].getFileName is not a function
    at Object.install (/Users/masaru/.atom/packages/linter-clojure/node_modules/atom-package-deps/lib/main.js:15:47)
    at Object.module.exports.activate (/Users/masaru/.atom/packages/linter-clojure/lib/init.coffee:11:34)
    at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:170:19)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:150:32
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:92:15)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:143:26
    at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:140:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:512:21)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:495:29
    at Config.module.exports.Config.transact (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:311:16)
    at PackageManager.module.exports.PackageManager.activatePackages (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:490:19)
    at PackageManager.module.exports.PackageManager.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:474:46)
    at AtomEnvironment.module.exports.AtomEnvironment.startEditorWindow (/Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:671:21)
    at Object.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/initialize-application-window.js:38:8)
    at Object.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/initialize-application-window.js:49:4)
    at Module._compile (module.js:434:26)
    at Object.defineProperty.value [as .js] (/Applications/Atom.app/Contents/Resources/app.asar/src/compile-cache.js:190:21)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at setupWindow (file:///Applications/Atom.app/Contents/Resources/app.asar/static/index.js:79:5)
    at window.onload (file:///Applications/Atom.app/Contents/Resources/app.asar/static/index.js:35:9)

Commands

Config

{
  "core": {
    "disabledPackages": [
      "autocomplete",
      "proto-repl"
    ],
    "audioBeep": false,
    "ignoredNames": [
      ".meteor"
    ],
    "themes": [
      "isotope-ui",
      "zenburn-syntax"
    ]
  },
  "linter-clojure": {
    "clojureExecutablePath": "/Users/masaru/.m2/repository/org/clojure/clojure/1.7.0/clojure-1.7.0.jar",
    "javaExecutablePath": "/usr/bin/java"
  }
}

Installed Packages

# User
Parinfer, v0.8.1
Stylus, v1.2.1
atom-html-preview, v0.1.13
auto-indent, v0.5.0
autocomplete-paths, v1.0.2
coffee-compile, v0.20.0
color-picker, v2.0.13
emmet, v2.3.14
file-icons, v1.6.11
haskell-ghc-mod, v1.1.5
isotope-ui, v2.7.0
language-babel, v2.5.0
language-fish-shell, v1.0.2
language-haskell, v1.5.1
language-jade, v0.6.2
language-scala, v1.1.4
language-spacebars, v0.2.2
linter, v1.11.2
linter-clojure, v1.1.0
linter-eslint, v5.2.1
minimap, v4.16.1
regex-railroad-diagram, v0.10.4
select-rectangle, v1.0.2
source-preview-babel, v0.1.1
space-tab, v0.4.2
sync-settings, v0.6.0
zenburn-syntax, v0.0.0

# Dev
No dev packages

After installation. Any advice?
Thanks for making this plugin!

We're in the process of replacing linter with a rewrite. Our central issue for tracking the plan is https://github.com/AtomLinter/linter-plus/issues/29. We're working hard to make this a smooth transition for you and for your users.

Please let us know here if you'd prefer to do the work yourself. If you have any questions or concerns please join us in our room on gitter.

I get the following exception in atom 1.6.2 on linux. I just installed it and have nothing configured.

TypeError: XRegExp is not a function
    at Object.parse (/home/boris/.atom/packages/linter-rubocop/node_modules/atom-linter/lib/helpers.js:424:18)
    at /home/boris/.atom/packages/linter-clojure/lib/init.coffee:31:20
    at /home/boris/.atom/packages/linter-clojure/lib/init.coffee:31:20

AtomLinter v0.X.Y API has been deprecated. Please refer to the Linter docs to update and the latest API: https://github.com/atom-community/linter/wiki/Migrating-to-the-new-API

Object.activate (/Users/egon/.atom/packages/linter/lib/main.coffee:51:8)
Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:240:19)
<unknown> (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:221:30)
Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:165:15)
Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:213:14)
PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:452:21)

I use linter/linter-eslint every day and depend on it heavily. I think I've got linter-clojure set up correctly, but can't get any linting errors to show up. These errors have no warnings:

(ns guestbook.routes.home
  (:require [guestbook.layout :as layout]
            [compojure.core :refer [defroutes GET]]))  ;; missing POST

(defroutes home-routes
  (POST "/message" request (save-message! request))

This doesn't give a linting error (too many parens, undeclared variable):

(+ 1 2)))))
wat

I don't think it's a problem with how linting errors are displayed because those are set in the main linter package and I see them properly with linter-eslint.

This makes me think I have something set up incorrectly, but I've gone through closed issues and docs and can't see anything wrong (and I get no errors):

  "linter-clojure":
    clojureExecutablePath: "/Users/jeffers/.m2/repository/org/clojure/clojure/1.7.0/clojure-1.7.0.jar"
    javaExecutablePath: "/usr/bin/java"

clojure-1.7.0.jar is executable -rwxr-xr-x. I've restarted Atom. I've tried Clojure 1.6.0, 1.7.0, 1.8.0. I've turned off the parinfer package. I'm working in Clojure, not ClojureScript.

Either it's not setup correctly somehow or I don't know what type of errors it's checking for. Suggestions?