`nasdf-compilation-test-system` isn't aware of its scope about nyxt HOT 7 CLOSED

from nyxt.

I'm afraid I disagree for 2 reasons. On the one hand, asdf:test-system's scope are systems, not packages. On the other hand, the output of asdf:test-system must be stateless. With the current design, as you correctly note, the behaviour of (asdf:test-system "nyxt") is determined (list-subpackages :nyxt), which in turn depends on whether renderer packages are loaded or not.

I think that the right fix would be to change be behavior of list-subpackages as to account for the fact that some subpackages might belong to another system.

In the mean time, the offending symbols should be documented. Would you to open a PR on that topic @aartaka?

from nyxt.

the output of asdf:test-system must be stateless.

Yes, that's convincing.

In the mean time, the offending symbols should be documented. Would you to open a PR on that topic

I've proven myself unreliable in writing documenttion several times in the last couple of weeks 😛

from nyxt.

In the mean time, the offending symbols should be documented. Would you to open a PR on that topic

I've proven myself unreliable in writing documenttion several times in the last couple of weeks 😛

I'm not sure what you mean exactly, could you please explain?

from nyxt.

I've proven myself unreliable in writing documenttion several times in the last couple of weeks 😛

I'm not sure what you mean exactly, could you please explain?

I mean #3217 (comment)

from nyxt.

I've proven myself unreliable in writing documenttion several times in the last couple of weeks 😛

I'm not sure what you mean exactly, could you please explain?

I mean #3217 (comment)

I understand what you are saying. I too would be hesitant in your position. I also think it would be a good idea to move forward, and note that it was probably a comment said in frustration, rather than one to be taken at literal face value.

I think it would be a good idea for us as a team to practice patience, and forgiveness. Let bygones be bygones. I am personally trying not to hold any grudges for things that have happened, and I hope we are all together on the same team.

from nyxt.

I'm taking this one. It is a priority for the development team. The developers must be able to simply call test-system for a renderer system (e.g. nyxt/gtk) and all tests from systems depending on it should be tested too (namely nyxt).

The compilation tests (undocumented exports and unbound exports) must be handles gracefully, within the scope of the system being tested.

from nyxt.