Git Product home page Git Product logo

Comments (4)

jmercouris avatar jmercouris commented on May 25, 2024

Are there any reasons not to delete them?

from nyxt.

aadcg avatar aadcg commented on May 25, 2024

In my view, some of these commands should be demoted to functions:

  • clean-configuration
  • enable-hook-handler
  • disable-hook-handler

History commands

From all history commands below you suggest deleting history-forwards-query alone. What motivates this choice?

  • history-forwards
  • history-backwards-query
  • history-forwards-direct-children
  • history-forwards-maybe-query
  • history-forwards-query
  • history-forwards-all-query
  • history-all-owner-nodes-query
  • history-all-query
  • buffer-history-tree

load-file

What motivates your view? The fact that we have load-config-file and load-file is too general? Right now, I believe it should stay.


nyxt-init-time

I believe it should stay. Nyxt users value tweaking their systems so it seems useful.


set-action-on-current-suggestion

If we delete this command, then the user isn't able to set it dynamically. I think it should stay. At least until we change the prompt buffer UI/UX with regards to actions (if we ever do).


@jmercouris I've edited your top post.

I can do it once we reach a decision.

from nyxt.

aadcg avatar aadcg commented on May 25, 2024

@jmercouris mode record-input-field-mode defines 3 commands, and all have been marked for deletion. I took a cursory look and I'd suggest deleting the mode completely. I don't think it's a core feature.

@jmercouris you marked go-up for deletion. What about go-to-homepage, go-next and go-previous?

from nyxt.

jmercouris avatar jmercouris commented on May 25, 2024

Firstly. I am OK with all of your suggestions about what not to delete that you've listed above.

With regards to record-input-field-mode, yes, we can fully delete it.

With regards to go-up, go-next et al., the problem is that it works on so /few/ pages, and thus presents to the user a degraded experience. If we could generalize it for websites that do not support this pattern, or provide the user with a helpful message, we could leave them in.

from nyxt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.