`common-settings` improvements about nyxt HOT 6 CLOSED

With regards to UI quirk:

Strange bug behavior. One solution: set the background color of the section to the correct color. The height doesn't work as intended. I think this is a renderer bug.

from nyxt.

Oh, I also looked into the UI quirk, and it seems like a CSS flexbox thing.
I was able to fix it by using min-height: 100% instead of height: 100% in the main row div.

from nyxt.

Fascinating, I would have never guessed. I had an inkling it had to do with flexbox, but didn't imagine the design was so idiotic.

from nyxt.

@aadcg As we discussed, I pushed some of these fixes directly to master:

• The UI quirk was fixed in 307b2fa
• The auto-config-file serialization was changed to add newlines in a4e10cb

The vi-insert-mode thing you mentioned requires a more involved solution (and maybe even a discussion), so I'll open a PR for that later.

from nyxt.

We should close this issue and open a new one about VI mode exclusively, because it turns out that the best solution is not related to common-settings at all. @hgluka can you please do it? Thanks.

from nyxt.

Closing this because the common-settings improvements are done. For the vi-insert-mode discussion, I opened #3242.

from nyxt.