Introduced in GH-34 (commit 7dc98a6):

This catches and logs even the "errors" that we consider to be normal in a deferred function call that attempts to close a file that has potentially already been closed: file already closed

References

• https://golang.org/pkg/os/#pkg-variables

As noted on the issues below, some of the default exclusions for golangci-lint mute common linting errors that I wish to know about. Though it will generate some initial chatter to work through, I should explicitly disable default exclusions so that I see everything.

• atc0005/brick#92
• atc0005/todo#29
• atc0005/todo#22

I've got some scratch paper notes from when I worked on this which are worth including in this repo for future reference. See also atc0005/brick#39.

Swap out the GitHub Actions used for CI work with custom Docker containers from the atc0005/go-ci project.

refs atc0005/todo#22

See atc0005/send2teams#206 for details.

Replace hard-coded version with LTS alias for "latest version", supported by the actions/setup-node update to v2.2.0.

While useful, the current status badges link out to the SVG used to provide the current status, not the workflow results themselves.

Update all badges to use a syntax similar to 'GoDoc' or 'Latest Release' so that the badge displays, but also functions as a "GoTo" button as well.

The notes below are from a Google Keep entry I made almost two weeks ago. Some of the goals have been met, others have not. At some point I can extract incomplete items from these lists and create new feature issues in their own right.

Active Users and Hosts file

• Active sessions for username or IP address
• Total active sessions
• Total current sessions active for a user

Audit Log

• Events from Audit Log based on the provided session, username, or IP Address
• Login failures for an IP Address or username

Traffic log

• Last X minutes for username, IP address, or session ID (once we enable that)
• Total download size for a user per domain

While a for loop can be used to determine whether the termination results slice contains an error, having this function could be a useful to reduce client code.

These linting errors were surfaced from an upgraded golangci-lint:

activefile/activefile.go:141:2: G307: Deferring unsafe method "Close" on type "*os.File" (gosec)
	defer func() {
		if err := f.Close(); err != nil {
			// Ignore "file already closed" errors
			if !errors.Is(err, os.ErrClosed) {
				ezproxy.Logger.Printf(
					"filterEntries: failed to close file %q: %s",
					afr.Filename,
					err.Error(),
				)
			}
		}
	}()
auditlog/auditlog.go:164:2: G307: Deferring unsafe method "Close" on type "*os.File" (gosec)
	defer func() {
		if err := f.Close(); err != nil {
			// Ignore "file already closed" errors
			if !errors.Is(err, os.ErrClosed) {
				ezproxy.Logger.Printf(
					"AllSessionEntries: failed to close file %q: %s",
					alr.Filename,
					err.Error(),
				)
			}
		}
	}()
make: *** [Makefile:67: linting] Error 1

See also atc0005/brick#116 and atc0005/brick#114.

• https://securego.io/docs/rules/g304.html
• https://golang.org/pkg/path/filepath/#Clean

As of v0.5.0 of the atc0005/go-ci project, images are available from both ghcr.io and index.docker.io.

Switch to ghcr.io to:

• speed up CI runs
• reduce bandwidth demands on Docker Hub
• increase availability of images

terminate.go:81:10: G204: Subprocess launched with variable (gosec)
                cmd := exec.Command(
                        executable,
                        SubCmdNameSessionTerminate,
                        session.SessionID,
                )

Since all of the arguments are variables (as that's sort of the point of this library?), I'm not yet sure what the fix is for this (or even if there is a fix).

Running into a specific case today where having that bundled in would prove useful. Thus far the workflow is to gather the user sessions (which contains Username, IP Address and Session ID values) and then calling the Terminate() method. The results from that method leave out of the IP Address value previously associated with the Session ID.

The client code can build this support in, but including this information would be helpful.

Spinning this repo/project off to collect the EZproxy-related code that I've written while working on the atc0005/brick project. What I've written thus far is very basic, but the hope is that this will serve as a useful starting point for further work/project as I continue to learn Go.

https://pkg.go.dev/badge/

See atc0005/todo#20 for details.

Having this available for all custom types, but especially for collections types would come in handy for a variety of use cases with a current project I'm working on. Presumably this would be useful for others as well.