ataulm / art-collector Goto Github PK

To finish the app links work, will need to upload the JSON thingy to http://art-collector.ataulm.com/ with the SHA of the signing key specified.

Create a debug key and upload it to the repo so that it works for anyone building the app from the git repo.

It's not an issue for Glide really, but just as a placeholder for this issue I faced with Picasso. The aim of this issue would be to learn the best way to add a singleton scoped to the application in this project.

e92412d

There's a bug in the Harvard API (as far as I can tell) where the primaryimageurl is null for some images when fetching the object by its object ID.

This has been made nullable in the API model to workaround the bug, but it's unclear when the image is taking ages to load, and when it'll never load because of the bug.

Fixing issue would make it clear. Consider:

• placeholder image this is taken care of by the background set in #18
• error image
• what happens when Picasso.load(null)? If it's not an immediate error (shows placeholder/error), make this clear too

#12 introduces deep links. up navigation is suitable now.

• up from painting goes to artist
• up from artist goes to gallery

if painting/artist was opened from this app, it should stay in this task
else if from another task, it should start a new task

it's explained here: https://developer.android.com/training/implementing-navigation/ancestral

Specifically:

• All Harvard Art Museums API content that is located on your website must include a link back to the location of the content on the Harvard Art Museums website.
• You must identify all Harvard Art Museums content on your website as originating from the Harvard Art Museums.

... I think.

Since they're separate APKs, I don't think it'll be applied just because it's specified in the app module.

When working on this, comment on the PR with notes about R8 and what it means with regard to Proguard.

As discussed in #10

Some monster increased the network request size to 100.

Instead of this, we should consider displaying pages of a lower size, that will fetch the next page when it needs to.

https://codelabs.developers.google.com/codelabs/android-paging/

Storing stuff locally too, it'll be interesting to have a different paging size when loading from the database, vs loading from the network 🤔