Subhalo values not being populated in mock when using SubhaloPhaseSpace about halotools HOT 2 OPEN

Adding on some more information. I found that this also affects features like RadialSatelliteAlignmentStrength. In RadialSatelliteAlignmentStrength, the alignment strength is calculated using the distance between the satellite galaxy and the host halo.

If I use the fix I mentioned in the previous comment (Overwriting the satellite galaxy halo information with their subhalos using SubhaloAlignment model) this overwrites the halo_x, halo_y, and halo_z with the values of the subhalo the satellite galaxy resides in rather than the values for the host halo. This causes issues when using RadialSatelliteAlignmentStrength as all the distances are now calculated to be zero.

So I think either we should fix this upstream and fix the RadialSatelliteAlignmentStrength model to account for that (I also have some notes on the form of the equation used there I think we should change), or if keeping the host halo information in the galaxy_table is preferable, we need to make sure the models intended to align with subhalos have the halocat information and properly reference that.

from halotools.

Hmm, ok, thanks for following up. We should probably find a time to have some discussion of this then.

from halotools.