Git Product home page Git Product logo

Comments (3)

aphearin avatar aphearin commented on July 17, 2024

This is useful to know. Halotools just directly uses the publicly available Rockstar subhalo catalogs, so these outlier halos are inherited from the upstream data. I'm not sure what failure mode this would signify. One innocuous explanation would be that these halos are perfect spheres. What are their values of b/a and c/a?

Regardless, probably the simplest treatment is as you say: to just mask out the outlier halos before proceeding with any further preprocessing.

from halotools.

nvanalfen avatar nvanalfen commented on July 17, 2024

For these 39 halos, the 'halo_b_to_a' and 'halo_c_to_a' values are all zero.

from halotools.

aphearin avatar aphearin commented on July 17, 2024

Hmm, ok, thanks for checking. I would have guessed that if these were perfect spheres then c/a and b/a would be unity, not zero. But of course it's possible that when Rockstar encounters such a rare edge case, it just uses zero for the fill value instead of unity. It's good that you raised this issue in case other people encounter it and go poking around for whether it has been noticed before. But since this is such a tiny fraction of objects, presumably throwing these subhalos out will not impact a cosmological analysis, so I think we should close this issue for now until we find that this is creating some downstream problem.

from halotools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.