astropy / ccd-reduction-and-photometry-guide Goto Github PK
View Code? Open in Web Editor NEWRead the CCD guide here:
Home Page: http://www.astropy.org/ccd-reduction-and-photometry-guide/
License: BSD 3-Clause "New" or "Revised" License
Read the CCD guide here:
Home Page: http://www.astropy.org/ccd-reduction-and-photometry-guide/
License: BSD 3-Clause "New" or "Revised" License
From running notebook 01.04:
WARNING: AstropyDeprecationWarning: The MexicanHat2D class is deprecated and may be removed in a future version.
Use RickerWavelet2D instead. [
Please rename your default branch from master
to main
as part of astropy/astropy-project#151 , preferably by 2021-03-22. Also a friendly reminder to check documentation, workflows, etc., and update them accordingly. Please don't forget to communicate this change to your users and stakeholders. To summarize:
master
to main
, preferably by 2021-03-22.Once this is taken care of, you may close this issue.
This is an automated issue. If this is opened in error, please let @pllim know!
There are quite a few grammatical errors in this notebook but most importantly it ends with "Example 2: No overscan subtraction, but trim the images" but there is no link to the data provided.
This may mean changing the default dpi and plot size. Images are way too big now.
Should be a CC-by license in the book.
This suggestion was made by @tstibor at https://github.com/mwcraig/ccd-reduction-and-photometry-guide/pull/110#discussion_r330014215
โฏ python ccd-reduction-and-photometry-guide/notebooks/download_data.py
Downloading https://zenodo.org/record/3320113/files/combined_bias_100_images.fit.bz2?download=1
|=========================================================| 26M/ 26M (100.00%) 7s
Traceback (most recent call last):
File "ccd-reduction-and-photometry-guide/notebooks/download_data.py", line 10, in <module>
p.rename('combined_bias_100_images.fit.bz2')
File "/home/simon/.pyenv/versions/3.7.4/lib/python3.7/pathlib.py", line 1319, in rename
self._accessor.rename(self, target)
OSError: [Errno 18] Invalid cross-device link: '/tmp/simon/astropy-download-46280-ro2ysk3s' -> 'combined_bias_100_images.fit.bz2'
At some point, we'll want to add an author list.
Adding caching should avoid rebuilding the whole set of notebooks. For now, either all notebooks need to be rebuilt or none because some of them rely on the output of earlier notebooks to work.
From #5:
notebook 01.05 calibration overview still contains a note to self and seems to be missing a summary line at the end, perhaps it's not finished?
Attempts to install ccdproc under Python 3.7 using conda seem to trigger a reversion to python 3.6? A dependency issue?
It should be BSD 3-clause
The current version adds target="_blank"
to the link by putting it in braces at the end of a markdown link. That worked (I think?) when the links went through a markdown stage in the rendering in jupyter-book
, but they do not anymore.
Since HTML is valid markdown we might as well just add the link as HTML with the attributes we need.
It has been observed that due to a ":" in 01.02-IRAF-like:-photutils.ipynb and 01.03-SExtractor-like:-sep-and-photutils.ipynb files, one cannot successfully clone the repository.
$ git clone https://github.com/astropy/ccd-reduction-and-photometry-guide.git
Cloning into 'ccd-reduction-and-photometry-guide'...
remote: Enumerating objects: 1162, done.
remote: Total 1162 (delta 0), reused 0 (delta 0), pack-reused 1162
Receiving objects: 100% (1162/1162), 12.74 MiB | 4.54 MiB/s, done.
Resolving deltas: 100% (810/810), done.
error: invalid path 'notebooks/photometry/01.02-IRAF-like:-photutils.ipynb'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'
Removing the ":" in those file names fixed the problem and enabled successful cloning of this repository.
Thank you.
Not sure how to fix this...
When first loading the Palomar data, if we want to be consistent with previous notebooks, we should use
calibrated_images = Path('./python_imred_data')
not
calibrated_images = Path('./')
as it currently is. However, even with that, the reduced dark file doesn't appear to be exist there.
Assuming this file is downloadable, include a link, if not, if it was supposed to be produced in a previous notebook, link to that notebook.
This notebook refers to "An astronomical image like the one shown below" without actually showing an image! One should probably be added or the first sentence restructured.
I've always used the mode to scale (sky/twilight) flats since I worry about the median being biased high by stars. This is obviously more processing intensive, though, so there's a trade-off. Can be implemented with statistics.mode or scipy.stats.mode.
What works:
trimmed_bias.data = trimmed_bias.data.astype('float32')
Great idea, though! Would be nice to have some sort of option to set property in CCDData to do this automatically when writing files.
jpm
There is a missing comma on line 74 of the notebook that prevents the notebook from loading.
Good examples of this are in the overscan notebook:
The guide is at https://github.com/orgs/astropy/projects/4 and the broken link is here: https://github.com/mwcraig/ccd-reduction-and-photometry-guide/pull/198#pullrequestreview-370061482
Probably due to some reorganization in the past, there users are asked to process python_imred_data files that don't exist. I found a link in the 02.01 notebook that said
The data for this example can be downloaded from [http://www.stsci.edu/~etollerud/python_imred_data.tar](http://www.stsci.edu/~etollerud/python_imred_data.tar)
I suggest adding this link right above that cell in the notebook.
Some specific questions:
These are short, text-only pages.
Not sure what is generating this one; comes up in running 01.04
/Users/mattcraig/development/ccd-reduction-and-photometry-guide/notebooks/image_sim.py:121: FutureWarning: Using a non-tuple sequence for multidimensional indexing is deprecated; use `arr[tuple(seq)]` instead of `arr[seq]`. In the future this will be interpreted as an array index, `arr[np.array(seq)]`, which will result either in an error or a different result.
dark_im[[hot_y, hot_x]] = hot_current * exposure_time / gain
The suggestion was made here: https://github.com/mwcraig/ccd-reduction-and-photometry-guide/pull/105#discussion_r311702332
When running the construction of a realistic (synthetic) image in notebook 01.04, I get
image_sim.py:121: FutureWarning: Using a non-tuple sequence for multidimensional indexing is deprecated; use `arr[tuple(seq)]` instead of `arr[seq]`. In the future this will be interpreted as an array index, `arr[np.array(seq)]`, which will result either in an error or a different result.
dark_im[[hot_y, hot_x]] = hot_current * exposure_time / gain
Looks like the indexing for dark_im
needs to be fixed.
Ideally across notebooks too...
Being anal, but the first sentence of the "Impact of combining images on noise" section likely needs to be reworked for clarity.
It depends on a 'reduced' directory of Palomar reduced biases that doesn't exist.
Rebuilding takes a while and the artifact is being built/uploaded for the PR so it ought to be possible to grab that instead of rebuilding.
The call to
ccd = CCDData.read('/Users/mattcraig/Desktop/2018-07-23-reduced/kelt-16-S001-R001-C110-r.fit')
is likely to work only on Matt Craig's laptop... I have a copy of the file if we need to make it publicly available.
[XXX]()
"When calibrating the dark frames from Palomar you have the code state:
for ccd, file_name in ex1_darks_raw.ccds(imagetyp='DARK', # Just get the bias frames
ccd_kwargs={'unit': 'adu'}, # CCDData requires a unit for the image if
# it is not in the header
return_fname=True # Provide the file name too.
):
The comments in the code should say you are getting just the DARK frames.
Also, what does showing the reduced frames after triming the overscan in the 'calibrating dark frames' loop supposed to show? I think you need to reload the directory via:
ex1_images_reduced = ImageFileCollection(ex1_path_reduced)
otherwise you show the File Collection before the newly reduced data was added.
Couldn't do anything with the example-thermo-electric
data because it isn't available.
These notebooks are ready for copy editing:
The default for this changed in astropy 4.0 from True
to False
. We need True
for these images to render well.
The issue in the first draft was that stars were totally visible in the output image.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.