simmetis's People
simmetis's Issues
Source file output not compatible with simulation input
When generating a Source
file using function source.Source.write()
, the output file is not compatible with the filename
attribute of simmetis.spectro.LMS
:
Traceback (most recent call last):
File "C:\Program Files\Python39\lib\site-packages\IPython\core\interactiveshell.py", line 3444, in run_code
exec(code_obj, self.user_global_ns, self.user_ns)
File "<ipython-input-4-e5f0f441e6c9>", line 1, in <module>
lms = sim.spectro.LMS("./test_data/stellar_spec_test.fits", "./notebooks/metis_spectro_LMS.config")
File "\\wsl$\Debian\home\username\SimMETIS-0.3\simmetis\spectro.py", line 98, in __init__
naxis3, naxis2, naxis1 = self.src_cube.shape
ValueError: not enough values to unpack (expected 3, got 2)
The header in the generated file is also different from the header of the test_data/LINE_3D_013.fits file given in example.
A method to generate a Source
that can be read by LMS
seems to be lacking.
Include emission from entrance window
While data/TC_window_METIS.dat gives an emissivity spectrum of the entrance window, it is not yet possible to include this contribution in SimMETIS. In N band the window contributes about 10% to the total background, in Q band the background is entirely dominated by the emission from the window. Q band simulations are therefore not yet possible.
Implement Radiometry table ASAP
The telescope_mirrors_tbl
needs to be implemented asap so that we can use the the actually mirror TC files when calling _gen_master_tc()
. As it stands at the moment, _gen_master_tc()
still relies on SCOPE_NUM_MIRRORS
and SCOPE_M1_TC
for generating the preset global transmission curves.
Instead of doing this, the _gen_master_tc()
should read in the mirrors_telescope.tbl
and add the individual transmission curves to the preset curve, e.g. self.tc_mirror
etc
File EC_pickles.fits is missing
When generating a Source
using the star()
function, the software needs the data/EC_pickles.fits file which is not presents. The file needs to be downloaded from the SimCADO github.
Many variables are defined multiple times and it is unclear to the user which ones are taken
- the gain is defined in the config file (FPA_GAIN) and also in the file linked at FPA_CHIP_LAYOUT
- the temperature is defined in the config file (SCOPE_TEMP) and also in the file linked at SCOPE_MIRROR_LIST
Reference star spectrum is hard coded
In source.py, the reference star spectrum is hard coded in the function calling _get_refstar_curve. It should be a parameter defined e.g. in a central config file (not necessarily visible to the user).
Search path for data files is inconsistent
For some files (e.g. the one defined in SCOPE_MIRROR_LIST) a file in the working directory overwrites a system installation. For other files, e.g. the one defined in INST_FILTER_TC, only the system directory is searched and if it isn't there, a "ValueError" is thrown as the file doesn't exist (should be a file not found error...).
Permit Readnoise as number
Currently, FPA_READOUT_MEDIAN is passed to nghxrg to create a noise image. This is only applicable to the HAWAII detectors. It ought to be possible to bypass nghxrg and use FPA_READOUT_MEDIAN as the average readnoise to be realised by a Gaussian process.
Detector quantum efficiency curves shouldn't be called transmission curves
Since it is confusing
Re-assess grid resolution for spectral.TransmissionCurve
The choice of the grid in spectral.py:126 has a major impact on how long it takes to create the optical path object. Making the grid coarser makes the creation of the optical path object instantaneous, but later crashes Simcado.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.