assertchris / attempt-promise Goto Github PK

I like your way of thinking with this quite a lot (it's also nice to see some "multiple returns" with array destruction in the wild!)

but I do feel like, and please correct me if I'm wrong that the try-catch problem could be solved with vanilla JS.
This is because, and again please correct me if wrong, a promise is like a try block in and of itself, with optional catch blocks in the form of a call to the catch method or a second callback for then

to illustrate I take your example and transform it to vanilla JS

const id = session.get("id");

const [err1, user] = await attempt(User.find(id));

if (err1) {
  response.error("Oops! No user...");
  return;
}

const [err2, products] = await attempt(
  Product.where("user_id", user.id)
    .orderBy("updated_at", "desc")
    .limit(50)
    .fetch(),
);

if (err2) {
  response.error("Oops! Missing products...");
  return;
}

response.ok("here are your products...", products);

vanilla:

const id = session.get("id");

return User.find(id)
    .catch(e => response.error("Oops! No user..."))
    .then(user => Product.where("user_id", user.id).orderBy("updated_at", "desc").limit(50).fetch())
    .catch(e => response.error("Oops! Missing products..."))
    .then(products = > response.ok("here are your products...", products));

(I would like to note that I have some doubts about the vanilla one regarding the catch calls, in my expierence, but its been a while, the catch does not break the chain. However the information I just looked up(https://stackoverflow.com/a/20715224) suggest it does, so I wrote the code based on what I found);