assert-rs / completest Goto Github PK

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Pending Status Checks

These updates await pending status checks. To force their creation now, click the checkbox below.

• chore(deps): Update MSRV to v1.77

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): Update nushell (nu-cli, nu-cmd-lang, nu-command, nu-parser, nu-protocol, nu-test-support, reedline)

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Continuing discussion at #6 (comment)

The problem: By construing the home parameter as my actual $HOME directory, I accidentally overwrote the .zshenv file in it because completest creates a file of such a name there unconditionally. I think it’s a papercut that it would be nice to clarify.

The suggested solution:

1. Deprecate/remove new() because more specific names tend to be more descriptive (IMO, of course).
2. Rename “home” to “workdir” because it can be confused with an actual home directory and result in overwritten configuration files.
3. Add a new constructor with_temp_workdir(bin_root) that creates a temporary workdir automatically.
4. Probably also rename bin_root to something like shell_binary_dir_path.

EDIT: Clarify the problem.

A bin_root parameter isn't sufficient.

We should probably move it to a push_path(&mut self, path) or something.

See #6

To simplify tests using completest, I'd like to have an ability to set PS1="". Currently I'm forced to take into account the configured prompt (% ) in my assertions.

Hi 👋

I’m on macOS, trying to write a simple test case. This just outputs a bunch of files from the current directory, not bar, as it should have. When I source the completion script from the shell, it works fine.

    #[test]
    fn completest_reduction() {
        let script = r#"
#compdef foo

_foo () {
    compadd bar
    return 0
}
compdef _foo foo
"#;
        let term = completest::Term::new();
        let mut runtime = completest::ZshRuntime::new(PathBuf::from_str("/opt/homebrew/bin/zsh").unwrap(), PathBuf::from_str("./completest-temporary-directory").unwrap()).unwrap();
        runtime.register("foo", &script).unwrap();
        let output = runtime.complete("foo \t", &term).unwrap();
        dbg!(output);
    }

    Running unittests src/main.rs (target/debug/deps/complgen-fd528e5e370143a6)

running 1 test
[src/zsh.rs:404] output = "adaszko@pryk complgen % foo\nCONTRIBUTING.md                  e2e/                             psql.usage\nCargo.lock                       examples/                        psql.zsh\nCargo.toml                       help.usage                       pytest.ini\nLICENSE                          help.zsh                         run-e2e-tests.bash*\nREADME.md                        lsof.bash                        src/\nassets/                          lsof.zsh                         strace.fish\ncapture_postamble.zsh            my.bash                          strace.usage\ncapture_preamble.zsh             my.fish                          strace.zsh\ncargo.fish                       my.usage                         target/\ncompletest-temporary-directory/  my.zsh                           usage/\ndfa.dot                          pgservice.conf                   venv/\ndfa.svg                          proptest-regressions/"
test zsh::tests::completest_reduction ... ok