aspettl / delphi-sepa-xml Goto Github PK

If special characters are allowed and in the Mandate ID is an '&' it will not be excaped. So in the Field MndtID is a string with an unescaped '&' wich is not a valid SEPA-XML.

We need the "BtchBookg" parameter in XML output. We have changed source on our side, please add it to your code:

TCreditTransferPaymentInformation = class
private
...
fBtchBookg:string; // set it to "false" in onCreate
public
...
property BtchBookg: String read fBtchBookg write fBtchBookg;
...

and write it to XML right after "PmtMtd"

procedure TCreditTransferPaymentInformation.SaveToStream(const stream: TStream; const schema: String);
begin
SEPAWriteLine(stream, '');
SEPAWriteLine(stream, ''+SEPACleanString(PmtInfId)+'');
SEPAWriteLine(stream, ''+SEPACleanString(PmtMtd)+'');

//>>
SEPAWriteLine(stream, ''+SEPACleanString(fBtchBookg)+'');

in Current version your CharIsSEPAWhitelisted() function is removing the ; character, if we escape the strings like:

"CustomerCompany GmbH & Co. KG" to "CustomerCompany GmbH & amp; Co. KG"
after output it is written as "CustomerCompany GmbH &amp Co. KG" and the ; is missing.

Without escaping the & char the xml-file cannot be validated.
Add ; to your CharisSEPAWhitelisted() and everything works.

ps: Note that we had to insert a space between & and amp in above example to show it here ...

We have disabled your lines:

// if (CdtrAgt.OthrID = FIN_INSTN_NOTPROVIDED) and not SEPAIsGermanIBAN(CdtrAcct.IBAN) then Result.Append(INVALID_IBAN_NOT_DE);

because we're using this also with ibans in Luxembourg, Austria etc, its working so why should we show that warning ... remove it